Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gNMI-1.10] add InterfaceCountersUpdateDelayed deviation #3536

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

kjahed
Copy link
Contributor

@kjahed kjahed commented Oct 22, 2024

1- Add InterfaceCountersUpdateDelayed deviation for CISCO (see PR #2805)
2- Use lookup instead of get for component type. Some of the parent component may not map to any of identity types defined under OPENCONFIG_HARDWARE_COMPONENT, for those components type leaf would not be returned (see PR #2808).

@kjahed kjahed requested a review from a team as a code owner October 22, 2024 20:05
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 22, 2024

Pull Request Functional Test Report for #3536 / 887f5fb

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.10: Telemetry: Basic Check
Cisco 8000E status
gNMI-1.10: Telemetry: Basic Check
Cisco XRd status
gNMI-1.10: Telemetry: Basic Check
Juniper ncPTX status
gNMI-1.10: Telemetry: Basic Check
Nokia SR Linux status
gNMI-1.10: Telemetry: Basic Check
Openconfig Lemming status
gNMI-1.10: Telemetry: Basic Check

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-1.10: Telemetry: Basic Check
Cisco 8808 status
gNMI-1.10: Telemetry: Basic Check
Juniper PTX10008 status
gNMI-1.10: Telemetry: Basic Check
Nokia 7250 IXR-10e status
gNMI-1.10: Telemetry: Basic Check

Help

@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 12936412718

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 17.784%

Totals Coverage Status
Change from base Build 12923061920: 0.0%
Covered Lines: 2481
Relevant Lines: 13951

💛 - Coveralls

@kjahed kjahed marked this pull request as draft October 23, 2024 19:54
Copy link
Member

@dplore dplore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Your new function is better than the existing. Our intent is to test using gnmi.Subscribe with SAMPLE mode. I suggest you replace the existing fetchInAndOutPkts with your new function.

@dplore dplore self-assigned this Oct 24, 2024
@kjahed kjahed marked this pull request as ready for review November 26, 2024 16:10
@dplore
Copy link
Member

dplore commented Dec 3, 2024

/fptest virtual

@dplore dplore removed their assignment Dec 3, 2024
@dplore dplore self-requested a review December 3, 2024 03:48
@ram-mac
Copy link
Contributor

ram-mac commented Jan 22, 2025

@kjahed - Can you please take care of the comments requested by Darren?

@ram-mac ram-mac requested a review from a team as a code owner January 22, 2025 06:42
@kjahed kjahed force-pushed the kjahed/gnmi-1.10-uprev branch from 8f34263 to 394752b Compare January 23, 2025 19:14
@kjahed
Copy link
Contributor Author

kjahed commented Jan 23, 2025

@kjahed - Can you please take care of the comments requested by Darren?

@ram-mac done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants