-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gNMI-1.10] add InterfaceCountersUpdateDelayed deviation #3536
base: main
Are you sure you want to change the base?
Conversation
Pull Request Functional Test Report for #3536 / 887f5fbVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12936412718Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Your new function is better than the existing. Our intent is to test using gnmi.Subscribe with SAMPLE mode. I suggest you replace the existing fetchInAndOutPkts
with your new function.
/fptest virtual |
@kjahed - Can you please take care of the comments requested by Darren? |
8f34263
to
394752b
Compare
1- Add InterfaceCountersUpdateDelayed deviation for CISCO (see PR #2805)
2- Use lookup instead of get for component type. Some of the parent component may not map to any of identity types defined under OPENCONFIG_HARDWARE_COMPONENT, for those components type leaf would not be returned (see PR #2808).