Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-1.54: Remove add path configuration #3679

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yini101
Copy link
Contributor

@yini101 yini101 commented Jan 6, 2025

Disable add path on ixia since the test does not rely on add path.

Disable add path on ixia since the test does not rely on add path.
@yini101 yini101 requested a review from a team as a code owner January 6, 2025 16:54
@OpenConfigBot
Copy link

OpenConfigBot commented Jan 6, 2025

Pull Request Functional Test Report for #3679 / 216cc58

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.54: BGP Override AS-path split-horizon
Cisco 8000E status
RT-1.54: BGP Override AS-path split-horizon
Cisco XRd status
RT-1.54: BGP Override AS-path split-horizon
Juniper ncPTX status
RT-1.54: BGP Override AS-path split-horizon
Nokia SR Linux status
RT-1.54: BGP Override AS-path split-horizon
Openconfig Lemming status
RT-1.54: BGP Override AS-path split-horizon

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.54: BGP Override AS-path split-horizon
Cisco 8808 status
RT-1.54: BGP Override AS-path split-horizon
Juniper PTX10008 status
RT-1.54: BGP Override AS-path split-horizon
Nokia 7250 IXR-10e status
RT-1.54: BGP Override AS-path split-horizon

Help

@dplore dplore self-assigned this Jan 6, 2025
@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12657262776

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12646291135: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@dplore
Copy link
Member

dplore commented Jan 7, 2025

/fptest virtual

@dplore
Copy link
Member

dplore commented Jan 7, 2025

@yini101 , note this does not pass on cEOS:

https://gist.github.com/dplore/034940b29d45d5b67846269f90109fdf

@dplore
Copy link
Member

dplore commented Jan 7, 2025

Please address the issue in the attached gist. Thanks!

@yini101
Copy link
Contributor Author

yini101 commented Jan 8, 2025

@dplore Thank you for the review!
failed while setting /routing-policy: failed while unmarshaling Container routing-policy: {"openconfig-routing-policy:policy-definitions":{"policy-definition":[{"config":{"name":"ALLOW"},"name":"ALLOW","statements":{"statement":[{"actions":{"config":{"policy-result":"ACCEPT_ROUTE"}},"conditions":{"config":{"install-protocol-eq":"openconfig-policy-types:BGP"}},"config":{"name":"ALLOW"},"name":"ALLOW"}]}}]}}: error decoding JSON value for node routing-policy/policy-definitions/policy-definition[name='ALLOW']/statements/statement[name='ALLOW']/conditions/config: An unexpected element "install-protocol-eq" is present It was failing because of install-protocol-eq configuration.

Arista doesn't support or need install-protocol-eq leaf to suppress other routes from being accepted. Could you please consider adding deviation for it because other vendors may need it as per #3626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants