Adding README files for a new type of optics PMD 400G ZR plus #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction returns value in nanosecond by default, needs to convert it to second; 2) in zr_low_power_mode_test file, to use the transceiver disable OC path, the input needs to be transceiver name instead of interface name.
Pull Request Test Coverage Report for Build 12835770588Details
💛 - Coveralls |
jianchen-g
assigned ejbrever, ahsaanyousaf, amrindrr and Ankur19 and unassigned ejbrever and ahsaanyousaf
|
@jianchen-g Can you point out some differences that require us to have a separate test? Why can these changes not be incorporated in the same test script? |
…ach test item has its own folder, under which 400G ZR and ZR++ test scripts are separated.
jianchen-g
changed the title
|
@Ankur19 per offline discussion, i created a main folder for each testing item. Under each folder, the test scripts for both 400G ZR and ZR++ will be separated in individual sub-folders. |
…/<testname>/<testname>_test.go
|
@Ankur19 Hi Ankur, i have made the folder structure and name changes. Please review again. |
Ankur19
previously approved these changes
Jan 13, 2025
amrindrr
previously approved these changes
Jan 14, 2025
ahsaanyousaf
approved these changes
Jan 17, 2025
ahsaanyousaf
approved these changes
Jan 17, 2025
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
…nfig#3680) * bug fixes: 1) in zr_laser_bias_current_test file, the time.Duration function returns value in nanosecond by default, needs to convert it to second; 2) in zr_low_power_mode_test file, to use the transceiver disable OC path, the input needs to be transceiver name instead of interface name. * Adding README files for the testing of a new type of optics 400G ZR++ * add README file for zrp_input_output_power_test * restructed the test folder for two optics PMDs of 400G ZR and ZR++. Each test item has its own folder, under which 400G ZR and ZR++ test scripts are separated. * make sure test paths follow feature/<feature>/<subfeature>/<testkind>/<testname>/<testname>_test.go * rename folder name to resovle the feature root errors * rename folder name to test_item_tests to resovle the feature root errors * adding tests folder to resolve folder root errors for cd tests * adding folder named tests to resolve folder root errors * rename folder chromatic_dispersion * rename folder performance_metrics --------- Co-authored-by: anksaiki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new folder of tests' README files to validate a new type of optics called 400G ZR++. The test items are largely the same as the existing 400G ZR testing, however there are key differences which requires standalone scripts as opposed to the 400G ZR: 1) operational mode; 2) Tx output power; 3) optics PMD.