Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health 1.1 system_generic_health_check #3693

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Health 1.1 system_generic_health_check #3693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
15d674e
removing deviations that are not required and adding code for compone…
lvaish05 Jan 14, 2025
c4bce2e
Merge branch 'main' of https://github.com/lvaish05/featureprofiles in…
lvaish05 Jan 22, 2025
6cf808c
skipping test for FFF
lvaish05 Jan 22, 2025
3896ae7
Merge branch 'main' of https://github.com/lvaish05/featureprofiles in…
lvaish05 Jan 22, 2025
f092655
edited the check from lineCards to chassisLineCards
lvaish05 Jan 24, 2025
89dcced
Merge branch 'main' of https://github.com/lvaish05/featureprofiles in…
lvaish05 Jan 24, 2025
9d6fad9
Merge branch 'main' into lvaish_0114
lvaish05 Jan 24, 2025
1f2af45
Merge branch 'main' into lvaish_0114
lvaish05 Jan 29, 2025
08159dc
Merge branch 'main' into lvaish_0114
lvaish05 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions feature/system/health/tests/system_generic_health_check/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ platform_exceptions: {
vendor: JUNIPER
}
deviations: {
linecard_cpu_utilization_unsupported: true
consistent_component_names_unsupported: true
controller_card_cpu_utilization_unsupported: true
fabric_drop_counter_unsupported: true
linecard_memory_utilization_unsupported: true
qos_voq_drop_counter_unsupported: true
qos_inqueue_drop_counter_unsupported: true
}
Expand Down
43 changes: 42 additions & 1 deletion feature/system/health/tests/system_generic_health_check/system_generic_health_check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,22 @@ func TestComponentStatus(t *testing.T) {
controllerCards := components.FindComponentsByType(t, dut, controllerCardType)
lineCards := components.FindComponentsByType(t, dut, lineCardType)
fabricCards := components.FindComponentsByType(t, dut, fabricCardType)
fabrics := make([]string, 0)
for _, f := range fabricCards {
compMtyVal, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(f).Empty().State()).Val()
if !compMtyVal && ok {
fabrics = append(fabrics, f)
}
}
fabricCards = fabrics
chassisLineCards := make([]string, 0)
for _, lc := range lineCards {
compMtyVal, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(lc).Empty().State()).Val()
if !compMtyVal && ok {
chassisLineCards = append(chassisLineCards, lc)
}
}
lineCards = chassisLineCards
checkComponents := append(controllerCards, lineCards...)
checkComponents = append(checkComponents, fabricCards...)
if len(checkComponents) == 0 {
Expand Down Expand Up @@ -246,6 +262,20 @@ func TestLineCardsNoHighCPUSpike(t *testing.T) {

lineCards := components.FindComponentsByType(t, dut, lineCardType)
cpuCards := components.FindComponentsByType(t, dut, cpuType)
chassisLineCards := make([]string, 0)
for _, lc := range lineCards {
compMtyVal, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(lc).Empty().State()).Val()
if !compMtyVal && ok {
chassisLineCards = append(chassisLineCards, lc)
}
}

for _, lc := range chassisLineCards {
if !gnmi.Get(t, dut, gnmi.OC().Component(lc).Removable().State()) {
t.Skipf("Skip the test on non-removable linecard.")
}
}
lineCards = chassisLineCards
if len(lineCards) == 0 || len(cpuCards) == 0 {
t.Errorf("ERROR: No controllerCard or cpuCard has been found.")
}
Expand Down Expand Up @@ -288,10 +318,19 @@ func TestComponentsNoHighMemoryUtilization(t *testing.T) {

controllerCards := components.FindComponentsByType(t, dut, controllerCardType)
lineCards := components.FindComponentsByType(t, dut, lineCardType)
chassisLineCards := make([]string, 0)
for _, lc := range lineCards {
compMtyVal, ok := gnmi.Lookup(t, dut, gnmi.OC().Component(lc).Empty().State()).Val()
if !compMtyVal && ok {
chassisLineCards = append(chassisLineCards, lc)
}
}
lineCards = chassisLineCards
cardList := append(controllerCards, lineCards...)
if len(cardList) == 0 {
t.Errorf("ERROR: No card has been found.")
}

for _, component := range cardList {
t.Run(component, func(t *testing.T) {
query := gnmi.OC().Component(component).State()
Expand All @@ -301,7 +340,9 @@ func TestComponentsNoHighMemoryUtilization(t *testing.T) {
if componentType == lineCardType && deviations.LinecardMemoryUtilizationUnsupported(dut) {
t.Skipf("INFO: Skipping test for linecard component %s due to deviation linecard_memory_utilization_unsupported", component)
}

if componentType == lineCardType && !gnmi.Get(t, dut, gnmi.OC().Component(component).Removable().State()) {
t.Skipf("Skip the test on non-removable linecard.")
}
memoryState := componentState.GetMemory()
if memoryState == nil {
t.Errorf("ERROR: %s - Device: %s - %s: %-40s - Type: %-20s - Memory data not available",
Expand Down
Loading