Apply GNOISubcomponentPath deviation to the related tests #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Pull Request Test Coverage Report for Build 3842519988
💛 - Coveralls |
|
@sezhang2 could u please review this pr? |
sezhang2
previously approved these changes
Dec 9, 2022
kjahed
force-pushed
the
moji/gnoi_component_path
branch
from
dfb6d01 to
ddece7b
Compare
sezhang2
previously approved these changes
Dec 14, 2022
|
/gcbrun |
|
@sezhang2 can u please merge this pr? |
|
Looks like you requested the review from vosipchu. I can help merge after vosipchu approves this PR. |
|
I intended to add him as assignee, but added as reviewer by mistake. anyway we can wait for his approval. @vosipchu can u please let us know if u are ok merging this pr? |
mojiiba
force-pushed
the
moji/gnoi_component_path
branch
from
ddece7b to
7dcb6ac
Compare
|
/gcbrun |
mojiiba
force-pushed
the
moji/gnoi_component_path
branch
from
7dcb6ac to
5f37898
Compare
|
/gcbrun |
thesrinath
previously approved these changes
Jan 5, 2023
thesrinath
dismissed
their stale review
Tests still failing. The deviation logic seems to be backwards.
thesrinath
approved these changes
Jan 5, 2023
singh-prem
pushed a commit
to singh-prem/featureprofiles
that referenced
this pull request
Jan 17, 2023
…#853) * apply GNOISubcomponentPath deviation to related tests * gofmt
prinikasn
pushed a commit
that referenced
this pull request
Jun 30, 2023
* apply GNOISubcomponentPath deviation to related tests * gofmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch applies GNOISubcomponentPath to the related tests that use gnoi system APIs. Motivation for GNOISubcomponentPath is discussed in the previous pull #717.