Add support for PBLQ per-interface capabilities #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Physical/channelized interfaces could support a variety of Generator or Reflector capabilities. An optional field is added to each capability to report a list of supported interfaces. Should this field not be set, it is assumed that all interfaces are supported for the capability reported.
Pull Request Test Coverage Report for Build 12280713436Details
💛 - Coveralls |
| @@ -326,6 +331,9 @@ message PacketInjectorCapabilities { | |||
| // Loopback modes that are supported by the device when using the packet | |||
| // injector mode. | |||
| repeated PacketInjectorLoopbackMode loopback_modes = 8; | |||
| // List of interfaces that support this capability. If this field is not | |||
| // populated then it is assumed that all interfaces are supported. | |||
| repeated string supported_interfaces = 9; | |||
There was a problem hiding this comment.
Not sure if this makes sense but an interface can have multiple capabilities right?
There was a problem hiding this comment.
The proto structs currently assumes system wide
Each capability is expanded in this patch set to accomodate a list of interfaces per capability so yes, the same interface could be reported under each capability if an interface supports multiple capabilities.
Another option is to create an entirely new capabilities API (or modify existing in non-backwards compatible) that does not make the system wide assumption from the start and allows for further granularity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Physical/channelized interfaces could support a variety of Generator or
Reflector capabilities. An optional field is added to each capability
to report a list of supported interfaces. Should this field not be set,
it is assumed that all interfaces are supported for the capability
reported.