Fix descriptions of root-delay and root-dispersion #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the comment about reconsidering units of root-delay. As long as it's uint32, milliseconds are the smallest possible units that allow it to have sufficient range. (The root delay values in NTP packets have a maximum value of about 18 hours. The range of a uint32 as milliseconds is 2^32 * 0.001 seconds = about 1193 hours. That's big enough, by far. The range of a uint32 as microseconds is about 1.193 hour = too small.) * The old description of root-delay matched the (single-server = non-"root") delay, but the *root* delay is accumulated across strata. * The old description of root-dispersion was not clearly differentiated from the (single-server = non-"root") dispersion. This change suggests the question: Does it make sense for these leaf nodes to be the root values, rather than the single-server values? I think the answer is yes, because the root delay and dispersion are included among the fields in NTP packets.
|
No major YANG version changes in commit dd5df4d |
|
I included these description updates in #1023, so this PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change suggests the question: Does it make sense for these leaf nodes to be the root values, rather than the single-server values? I think the answer is yes, because the root delay and dispersion are included among the fields in NTP packets.
Change Scope
Platform Implementations