-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the up-transitions leaf from the async and echo sub-containers into the state container. #1252
Conversation
/gcbrun |
No major YANG version changes in commit 4f19162 |
/gcbrun |
1 similar comment
/gcbrun |
/gcbrun |
Hi @dplore, what is pending on this PR? Merging seems to be blocked. |
This will be reviewed in the Feb 25, 2025 OC Operators meeting. If there is no objection, we'll set to "last-call" status for any further comments and then merge after the last-call period ends (typically two weeks). The change as proposed is a breaking change because a leaf is deleted (moved). Unless there's a strong reason to delete this leaf, it should instead have a status field set to |
Thank you for the clarification. I deprecated the leaf instead of deleting it, and updated the description to reflect that as well as specify the new leaf to be used in its place. |
Due to the other bfd contributions which were just merged, please update |
/gcbrun |
/gcbrun |
/gcbrun |
/gcbrun |
Change Scope
Currently there is an up-transitions leaf in both the async and echo subcontainers:
/bfd/interfaces/interface/peers/peer/state/echo/up-transitions
/bfd/interfaces/interface/peers/peer/state/async/up-transitions
I have moved this leaf into the state container, so that it is grouped with the failure-transitions leaf:
/bfd/interfaces/interface/peers/peer/state/failure-transitions
/bfd/interfaces/interface/peers/peer/state/up-transitions