Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the up-transitions leaf from the async and echo sub-containers into the state container. #1252

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

AnilKR123
Copy link
Contributor

Change Scope

Currently there is an up-transitions leaf in both the async and echo subcontainers:

/bfd/interfaces/interface/peers/peer/state/echo/up-transitions
/bfd/interfaces/interface/peers/peer/state/async/up-transitions

I have moved this leaf into the state container, so that it is grouped with the failure-transitions leaf:

/bfd/interfaces/interface/peers/peer/state/failure-transitions
/bfd/interfaces/interface/peers/peer/state/up-transitions

@AnilKR123
Copy link
Contributor Author

Hi @dplore,

I have launched this pr to address the issue discussed in: #1251.

Thanks,

Anil

@dplore
Copy link
Member

dplore commented Feb 19, 2025

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Feb 19, 2025

No major YANG version changes in commit 4f19162

@dplore
Copy link
Member

dplore commented Feb 19, 2025

/gcbrun

1 similar comment
@dplore
Copy link
Member

dplore commented Feb 19, 2025

/gcbrun

@dplore
Copy link
Member

dplore commented Feb 20, 2025

/gcbrun

@AnilKR123
Copy link
Contributor Author

Hi @dplore, what is pending on this PR? Merging seems to be blocked.

@dplore
Copy link
Member

dplore commented Feb 21, 2025

This will be reviewed in the Feb 25, 2025 OC Operators meeting. If there is no objection, we'll set to "last-call" status for any further comments and then merge after the last-call period ends (typically two weeks).

The change as proposed is a breaking change because a leaf is deleted (moved). Unless there's a strong reason to delete this leaf, it should instead have a status field set todeprecated. Please also update the description to indicate it's deprecated and what should be used in it's place so the information is easy to reference in documentation.

@AnilKR123
Copy link
Contributor Author

Thank you for the clarification. I deprecated the leaf instead of deleting it, and updated the description to reflect that as well as specify the new leaf to be used in its place.

@dplore
Copy link
Member

dplore commented Mar 5, 2025

Due to the other bfd contributions which were just merged, please update release/models/bfd/openconfig-bfd.yang to resolve conflicts. Otherwise, this LGTM. Setting to last call for March 18th,2025

@dplore
Copy link
Member

dplore commented Mar 5, 2025

/gcbrun

@dplore dplore self-assigned this Mar 5, 2025
@dplore
Copy link
Member

dplore commented Mar 5, 2025

/gcbrun

@dplore
Copy link
Member

dplore commented Mar 5, 2025

/gcbrun

@dplore
Copy link
Member

dplore commented Mar 5, 2025

/gcbrun

@dplore dplore merged commit 2e6e16a into openconfig:master Mar 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: last-call
Development

Successfully merging this pull request may close these issues.

3 participants