-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static route next network-instance option #1259
base: master
Are you sure you want to change the base?
Static route next network-instance option #1259
Conversation
This reverts commit 3be8ac2.
/gcbrun |
No major YANG version changes in commit 7a75980 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
It looks like this PR needs to be caught up to the latest commit in master? It's missing the changes from earlier commits in master.
Also this PR contains commits for the uRPF changes which is probably not intended.
@@ -298,11 +304,44 @@ module openconfig-local-routing { | |||
uses local-static-state; | |||
} | |||
|
|||
container next-network-instance { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should follow the precedence from the afts model where a lookup is intended to be triggered in a different, destination network-instance. The leaf used there is next-hop-group-network-instance
A similar pattern for static-routes could be:
/network-instances/network-instance/protocols/protocol/static-routes/static/config/next-hop-group-network-instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this change analogous to #1219, i.e., resolution of next-hop in a different network-instance?
If so, Isn't it better & flexible to emulate the same model here for IP routes as well? i.e., Adding a next-hop-network-instance
leaf under /network-instances/network-instance/protocols/protocol/static-routes/static/next-hops/next-hop/config
, same leaf should be added in next-hop/state
container as well.
Please correct me if I completely misunderstood the intent of this PR.
Implementation references contain links to two different features:
|
Good point @LimeHat . I was thinking of juniper-like implementation. And I do have use case for it. What is your take? |
So the destination NI leaf should probably be added to the nexthops as suggested above. For example: We also need some additional description to clarify the behavior.
Is that a good description on what you're looking specify @rszarecki |
Change Scope
This change introduces new option for static route, allowing further destination lookup in context of other network-instance.
This change is non-disruptive.
Platform Implementations
implementation output.