-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootz skip ownership check #908
base: master
Are you sure you want to change the base?
Conversation
No major YANG version changes in commit 8c4f1cc |
"This field controls if the device should validate the ownership in | ||
the next bootz workflow"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This field controls if the device should validate the ownership in | |
the next bootz workflow"; | |
"This field controls if the device should validate the ownership | |
voucher as described in the bootz bootstrapping service API | |
flow."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I denied your suggestions, because we need to call it out that it's for next bootz workflow that runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was attempting to be more precise on two dimensions:
-
This leaf refers specifically to the bootz bootstrapping service which is a specific step within the bootz API Flow. (although admittedly, the bootz specification specifies a section header as API Flow but then also uses the words 'workflow' occasionally inside the API Flow section, I guess API Flow and Workflow are the same thing?).
-
This setting should be honored for every invocation of the bootstrapping service, not just the 'next' workflow? I guess since the configuration is persistent, the 'next' workflow could be considered all future workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent container is Bootz, so the all the leaves here is about the Bootz spec.
@marcushines @xw-g do you want to continue with this PR? If yes please review |
/gcbrun |
Add the support of skipping ownership validation in Bootz.
There are 3 sequentially dependent PRs to introduce this changes.