-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hashing model #959
Add hashing model #959
Conversation
No major YANG version changes in commit 5c1353e |
Compatibility Report for commit 10215ae: |
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Note: Added reference in the PR description to include SONIC ecmp/lag hash. |
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Hashing algorithms subtree as been updated as per the suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of extra containers recommended to encapsulate all the hashing configurating into '/system/hashing' and to limit the scope of vendor augments to '/system/hashing/algorithms'
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This was reviewed again in Nov 21, 2023 OC operators meeting without objection. Thank you for the model and all the changes.
* Add traffic load balancing hashing model in OC --------- Co-authored-by: Darren Loher <[email protected]>
This PR replaces #939
Change Scope
Introduce a hashing policy which can used to
Add hashing-policy to interfaces to allow configuration of which algorithm to use on a per interface basis
Add hashing-policy to
/system
to allow configuration of an algorithm used by all the ports in an implementationIt is expected that implementations will vary widely in which specific options they support as these are hardware dependent. The goal is to define a what is operationally useful and supported by at least a subset of hardware. Other hardware may offer only partial support or even no support.
This change is backward compatible.
Implementations
Arista EOS - port-channel load-balance - defines a variety of configuration items which are specific to different hardware platforms. They include references to hash policies with attributes including hash polynomials, hash seeds, and hash fields
JunOS - per flow load balancing on hash values has partial support of the configuration. It defines a way to configure a hash seed on some hardware platforms. forwarding-options/hash-key allow configuration of per-prefix and mac address based balancing. There is no support for configuring different hash algorithms nor to configure per interface.
Cisco IOS-XR bundle-hash allows configuring the hash key based on a list of fixed options
Nokia SR Linux system/load-balancing/hash-options allows hash seed and some hash key configuration support. There doesn't appear to be support for configuring different hash algorithms.
SONIC ecmp/lag hash contains configuration for selecting packet fields for hash computation. These are set at a global level.
Tree View
Without augment for vendor
With augment for vendor