Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nsexec spring cleaning part I #3982

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Nsexec spring cleaning part I #3982

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0c7ce5
makefile: quote TESTFLAGS when passing to containerised make
cyphar Aug 4, 2023
c6e7b1a
libct: initProcess.start: fix sync logic
kolyshkin Aug 16, 2023
f81ef14
libcontainer: sync: cleanup synchronisation code
cyphar Aug 8, 2023
20b95f2
libcontainer: seccomp: pass around *os.File for notifyfd
cyphar Aug 8, 2023
5c7839b
rootfs: use empty src for MS_REMOUNT
cyphar Aug 2, 2023
8aa97ad
nsexec: remove cgroupns special-casing
cyphar Aug 1, 2023
1f25724
configs: fix idmapped mounts json field names
cyphar Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
makefile: quote TESTFLAGS when passing to containerised make 
Otherwise TESTFLAGS="-run FooBar" will result in TESTFLAGS=-run being
executed in the container.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
  • Loading branch information
@cyphar @kolyshkin
cyphar authored and kolyshkin committed Aug 16, 2023
commit b0c7ce51588cca89fa32772ccdb50397f218332f
4 changes: 2 additions & 2 deletions Makefile
View file
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ unittest: runcimage
-t --privileged --rm \
-v /lib/modules:/lib/modules:ro \
-v $(CURDIR):/go/src/$(PROJECT) \
$(RUNC_IMAGE) make localunittest TESTFLAGS=$(TESTFLAGS)
$(RUNC_IMAGE) make localunittest TESTFLAGS="$(TESTFLAGS)"

localunittest: all
$(GO) test -timeout 3m -tags "$(BUILDTAGS)" $(TESTFLAGS) -v ./...
@@ -115,7 +115,7 @@ integration: runcimage
-t --privileged --rm \
-v /lib/modules:/lib/modules:ro \
-v $(CURDIR):/go/src/$(PROJECT) \
$(RUNC_IMAGE) make localintegration TESTPATH=$(TESTPATH)
$(RUNC_IMAGE) make localintegration TESTPATH="$(TESTPATH)"

localintegration: all
bats -t tests/integration$(TESTPATH)