Ocrvs 6093 #6112
Merged
Ocrvs 6093 #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikukissa
reviewed
Oct 25, 2023
docker-compose.yml
Outdated
| @@ -76,6 +76,7 @@ services: | |||
| - OPENHIM_URL=http://openhim-core:5001 | |||
| - APPLICATION_CONFIG_URL=http://config:2021/ | |||
| - COUNTRY=${COUNTRY:-bgd} # PEN_TEST change to gbr | |||
| - COUNTRY_CONFIG_URL=http://countryconfig:3040 | |||
There was a problem hiding this comment.
Can we get rid of RESOURCE_SERVICE_URL?
…in core itself" This reverts commit 2ca4ccb.
rikukissa
approved these changes
Oct 25, 2023
rikukissa
approved these changes
Oct 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v1.3.2 #6112 +/- ##
=================================================
Coverage ? 86.33%
=================================================
Files ? 728
Lines ? 126525
Branches ? 11949
=================================================
Hits ? 109239
Misses ? 17281
Partials ? 5 ☔ View full report in Codecov by Sentry. |
rikukissa
approved these changes
Nov 8, 2023
Zangetsu101
force-pushed
the
release-v1.3.2
branch
from
db8d2d1 to
0d21560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Farajaland PR: opencrvs/opencrvs-farajaland#768