Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align e2e with action-menu #1135

Merged
merged 19 commits into from
Oct 29, 2024
Merged

fix: align e2e with action-menu #1135

merged 19 commits into from
Oct 29, 2024

Conversation

jamil314
Copy link
Collaborator

@jamil314 jamil314 commented Sep 30, 2024

action-menu

These changes require chromium v130. If you had already run some e2e test locally, you need to run npx playwright install to bump up your chromium.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@jamil314 jamil314 changed the title fix: align e2e with [action-menu](https://github.com/opencrvs/opencrvs-core/issues/7390) fix: align e2e with action-menu Sep 30, 2024
@ocrvs-bot
Copy link

Your environment is deployed to https://action-menu.opencrvs.dev.

Copy link
Member

@rikukissa rikukissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the errors in the diffs. Otherwise ok to merge

@jamil314 jamil314 merged commit 2768c62 into develop Oct 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants