Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove '' from consideration #1140

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Zangetsu101
Copy link
Collaborator

The previous address used to include an empty string which was taken into consideration when comparing with the new value.

The previous address used to include an empty string which was
taken into consideration when comparing with the new value.
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Zangetsu101 Zangetsu101 merged commit d860229 into develop Oct 14, 2024
3 of 4 checks passed
@Zangetsu101 Zangetsu101 deleted the fix-address-comparison-e2e branch October 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant