Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filler values for blank address lines in playwright tests #1141

Closed
wants to merge 1 commit into from

Conversation

tumbledwyer
Copy link
Collaborator

Core was changed to not show blank lines, which has broken tests here. Filling in the lines allows the tests to assume the same number of address lines

Core was changed to not show blank lines, which has broken tests here. Filling in the lines allows the tests to assume the same number of address lines
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@tumbledwyer tumbledwyer changed the title Added fillers for blank lines to pass tests Added filler values for blank address lines in playwright tests Oct 16, 2024
@ocrvs-bot
Copy link

Your environment is deployed to https://blank-line-fixes.opencrvs.dev.

@tumbledwyer tumbledwyer deleted the blank-line-fixes branch October 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants