Docker prune is in deploy script, cron schedule is off #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
rikukissa
reviewed
Nov 11, 2024
Comment on lines
44
to
51
| - name: 'Setup crontab to clean up docker images' | ||
| cron: | ||
| user: '{{ crontab_user }}' | ||
| name: 'cleanup docker images' | ||
| minute: '0' | ||
| hour: '0' | ||
| job: '/usr/bin/docker system prune -af >> /var/log/docker-prune.log' | ||
|
|
There was a problem hiding this comment.
Think we need to keep this for a while and set it to state: absent instead - otherwise it only doesn't get installed to new environments but never gets removed from the existing environments
There was a problem hiding this comment.
ok i am changing it right now
|
Your environment is deployed to https://prune-images-on-deploy.opencrvs.dev. |
|
@alsmk These changes have been moved to countryconfig right? In that case, can we close this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy.sh file contains the image prune operations
infrasttructure > server-setup > tasks > docker.yaml file now doesn't contains the docker prune operations