-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node to 18 #847
Upgrade node to 18 #847
Conversation
.github/workflows/deploy-prod.yml
Outdated
@@ -32,7 +32,7 @@ jobs: | |||
timeout-minutes: 60 | |||
strategy: | |||
matrix: | |||
node-version: [16.20.0] | |||
node-version: [18.19.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these are not actually used anywhere. I've removed these definitions in 1.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rikukissa should I revert this, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tahmidrahman-dsi I think it's fine to keep unless you want to remove the whole matrix
block
bd7709c
to
c602f41
Compare
* Update node version in Dockerfile * Update node version in workflow yml files * Add os configuration option in package.json * Add engines configuration option in package.json * Feedback changes * Add node options NODE_OPTIONS dns-result-order `ipv4first` * Upgrade node version in workflow file * Remove matrix block
* Code freeze 1.5.0 release * Update auth to go through gateway (#781) * fix auth api urls * add mongo url for search service * refactor: keep individual certificate endpoint only in dev * return composition id confirm registration endpoint in core (#797) * Add feature flags in application default config (#806) * chore: remove logrocket references (#811) * feature flag hotfix for client config prod * Upgrade node to 18 (#847) * Update node version in Dockerfile * Update node version in workflow yml files * Add os configuration option in package.json * Add engines configuration option in package.json * Feedback changes * Add node options NODE_OPTIONS dns-result-order `ipv4first` * Upgrade node version in workflow file * Remove matrix block * (state-transitions): remove openhim url and modify confirm registration url (#932) * Remove openhim url and modify confirm registration url * Remove openhim core and openhim console services * feat: enable gzip compression (#947) * feat: enable gzip compression * enable gzip for gateway and login * make SENTRY_DSN variable optional * fix: support node versions 18.x.x (#955) * build: use docker compose v2 in github workflow files (#956) * Merge pull request #937 from opencrvs/ocrvs-6410-mass-email-users * deps: remove openhim (#963) * Add smtp env vars in qa deploy config * Revert "Minor amend notification schema" This reverts commit b2c6e39. * fix: remove duplicate handlebars.js route * chore: update the certificate images with <image> instead of the patterns (#977) * feat: generate default address according to user's location (#978) * feat: add GATEWAY_URL env variable * feat: generate default address from user location * chore: remove initialValue from dynamicOptions * [HOTFIX] Mass email subject & content styles (#983) * Update body content styles to use linebreaks * Forward subject from variables instead of template * fix: change gateway web url to internal swarm one (#990) * docs: update CHANGELOG * set owner for backup server authorized_keys to be the backup user * minor fix to how download script cleans backup directories before applying downloaded backups * chore!: move configuration options (#1005) * Remove authentication from dashboard queries endpoint and update traefik rules * fix: remove authentication from dashboard queries endpoint and update traefik rules (#120) * Update CHANGELOG.md * Remove unintended formatting changes * Update jq images to official ones to avoid deprecation breakage (#122) * Update Docker and checkout actions to get rid of warnings (#121) * fix: add translations for different informants in print, issue & correction flow (#127) * french translation added for informants * updated changelog.md * Fix Correct item names in update modal for marriage declaration * don't require regLastLocation in Postman Event Notification (#115) * fix: simplify hierarchy now that it can be queried through graphql (#116) --------- Co-authored-by: Riku Rouvila <[email protected]> Co-authored-by: Md. Ashikul Alam <[email protected]> Co-authored-by: Tahmid Rahman <[email protected]> Co-authored-by: tahmidrahman-dsi <[email protected]> Co-authored-by: Tameem Bin Haider <[email protected]> Co-authored-by: Tameem Bin Haider <[email protected]> Co-authored-by: tahmidrahman-dsi <[email protected]> Co-authored-by: Niko Kurtti <[email protected]> Co-authored-by: Anamul Haque <[email protected]> Co-authored-by: Tareq <[email protected]>
No description provided.