curvefs/client: optimizing the read amplification problem(especial me… #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
from
7b68cd8 to
52b31c7
Compare
|
cicheck |
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
2 times, most recently
from
29e40b3 to
f98ba2e
Compare
|
cicheck |
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
4 times, most recently
from
710590c to
0c6705e
Compare
|
cicheck |
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
from
0c6705e to
fcba9a4
Compare
|
cicheck |
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
from
fcba9a4 to
5f69732
Compare
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
3 times, most recently
from
e21d0cc to
25d5735
Compare
|
cicheck |
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
from
25d5735 to
339a471
Compare
|
cicheck |
1 similar comment
|
cicheck |
wuhongsong
changed the title
wu-hanqing
approved these changes
Oct 20, 2023
201341
reviewed
Oct 20, 2023
201341
reviewed
Oct 20, 2023
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
from
339a471 to
f9d52b3
Compare
Wine93
reviewed
Oct 23, 2023
| @@ -0,0 +1,307 @@ | |||
| /* | |||
| * Copyright (c) 2021 NetEase Inc. | |||
| LOG(WARNING) << "download object: " << name << " timeout"; | ||
| return false; | ||
| } | ||
| } while (!s3ClientAdaptor_->GetDiskCacheManager()->IsCached(name)); |
There was a problem hiding this comment.
There are multi same operations, maybe you can use one function to replace this chain operation.
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
3 times, most recently
from
c025a09 to
17a4874
Compare
|
cicheck |
|
cicheck |
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
6 times, most recently
from
199e246 to
ab4d997
Compare
wuhongsong
force-pushed
the
memcached_to_disk_1008
branch
from
ab4d997 to
a954b46
Compare
|
cicheck |
Wine93
approved these changes
Oct 23, 2023
|
@201341 PTAL |
201341
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mcached)
memcached does not support partial reads (object size：4MB in Curve) of an object, but the io will not exceed 128KB in linux kernel(1MB in kernel 4.20+).so for sequential reads, this will cause memcached write amplification is：4MB/128KB = 40 .
To solve this problem, we cache the first read memcached object locally.