add ability to change capacity in fsinfo #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
h0hmj
commented
Oct 19, 2023
h0hmj
commented
- add mds rpc
- add tools-v2 command
SeanHai
reviewed
Oct 20, 2023
|
|
||
| // 3. update fs info | ||
| // set capacity | ||
| if (req->has_capacity()) { |
There was a problem hiding this comment.
check this at beginning, the step 1 and 2 are not required if capacity not exist.
There was a problem hiding this comment.
ok i will add parameter check in MdsServiceImpl::UpdateFsInfo
There was a problem hiding this comment.
It has been checked in mds servers. Do I still need to check here?
|
Need to add some unit tests |
done |
|
cicheck |
SeanHai
reviewed
Oct 20, 2023
curvefs/src/mds/mds_service.cpp
Outdated
| // request parameter check, we want at least one field that need to change | ||
| if (!request->has_capacity()) { | ||
| response->set_statuscode(FSStatusCode::PARAM_ERROR); | ||
| LOG(ERROR) << "UpdateFsInfo fail, request: " |
Signed-off-by: h0hmj <[email protected]>
SeanHai
approved these changes
Oct 20, 2023
|
cicheck |
Cyber-SiKu
reviewed
Oct 24, 2023
|
|
||
| // 3. update fs info | ||
| // set capacity | ||
| if (req->has_capacity()) { |
There was a problem hiding this comment.
It has been checked in mds servers. Do I still need to check here?
|
cicheck |
Signed-off-by: h0hmj <[email protected]>
|
cicheck |
Cyber-SiKu
approved these changes
Oct 24, 2023
|
cicheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.