[feat]curvefs/client: split io attr/data latency #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyber-SiKu
force-pushed
the
feat/curvefs/client/io_split_metric
branch
2 times, most recently
from
374bc6e to
8d2d8a0
Compare
|
cicheck |
SeanHai
approved these changes
Oct 23, 2023
wu-hanqing
reviewed
Oct 23, 2023
| @@ -220,6 +217,15 @@ CURVEFS_ERROR FuseS3Client::FuseOpWrite(fuse_req_t req, fuse_ino_t ino, | |||
| } | |||
|
|
|||
| inodeWrapper->GetInodeAttrLocked(&fileOut->attr); | |||
|
|
|||
| if (fsMetric_.get() != nullptr) { | |||
There was a problem hiding this comment.
should we remove this metric?
There was a problem hiding this comment.
no, this pr only care about latency.
| ::curve::common::UniqueLock lgGuard = inodeWrapper->GetUniqueLock(); | ||
| inodeWrapper->UpdateTimestampLocked(kAccessTime); | ||
| inodeManager_->ShipToFlush(inodeWrapper); | ||
| ioLatencyMetric_->readDataLatency << butil::cpuwide_time_us() - mid; |
There was a problem hiding this comment.
read data latency should put before L274?
Signed-off-by: Cyber-SiKu <[email protected]>
Cyber-SiKu
force-pushed
the
feat/curvefs/client/io_split_metric
branch
from
8d2d8a0 to
4072787
Compare
wu-hanqing
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List