Add startup parameters for chunkserver #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vigor-jpg
force-pushed
the
format
branch
2 times, most recently
from
6526177
to
4a7ad5b
Compare
|
Will this be compatible with all versions? If not, you need to do some processing |
Vigor-jpg
force-pushed
the
format
branch
2 times, most recently
from
4bf36b6
to
4076c41
Compare
Yes, I have made some change to make it compatible with previous version. |
|
How to config is shown in the figure above. |
caoxianfei1
reviewed
Oct 27, 2023
Comment on lines
76
to
80
| func (dc *DeployConfig) exist(i *item) bool { | ||
| _, ok := dc.config[i.key] | ||
| return ok | ||
| } | ||
|
|
caoxianfei1
reviewed
Oct 27, 2023
Comment on lines
177
to
184
| func (dc *DeployConfig) ExistChunkFilePoolAllocatedPercent() bool { | ||
| return dc.exist(CONFIG_CHUNK_FILE_POOL_ALLOCATED_PERCENT) | ||
| } | ||
|
|
||
| func (dc *DeployConfig) ExistChunkFormatThreadNum() bool { | ||
| return dc.exist(CONFIG_CHUNK_FORMAT_THREAD_NUM) | ||
| } | ||
|
|
caoxianfei1
reviewed
Oct 27, 2023
Comment on lines
142
to
147
| if dc.ExistChunkFilePoolAllocatedPercent() { | ||
| chunkserverArguments["chunkFilePoolAllocatedPercent"] = dc.GetChunkFilePoolAllocatedPercent() | ||
| } | ||
| if dc.ExistChunkFormatThreadNum() { | ||
| chunkserverArguments["chunkFormatThreadNum"] = dc.GetChunkFormatThreadNum() | ||
| } |
There was a problem hiding this comment.
Delete the function that determines whether it exists and use nil value for judgment.
May be we can use it:
if dc.GetChunkFilePoolAllocatedPercent() != 0 {
}
if dc.GetChunkFormatThreadNum() ！= 0 {
}
please push to the developer-activity branch.
There was a problem hiding this comment.
I think we can't judge whether it's empty by whether the return is 0 or not.
Signed-off-by: yyyyufeng <[email protected]>
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: opencurve/curve#2261
Curve PR: opencurve/curve#2775