[feat]curveadm: add export cmd for export the yaml that tools-v2 used #344

youarefree123 · 2023-11-14T13:16:54Z

Fixed: #315

add export cmd for export the yaml that tools-v2 used

Signed-off-by: Chengyu Liu <[email protected]>

update: wrong word spelling

Signed-off-by: ilixiaocui <[email protected]>

internal/errno/errno.go

cli/command/export.go

internal/task/task/common/export_toolsv2_conf.go

montaguelhz · 2023-11-14T14:42:48Z

internal/task/task/common/sync_config.go

+		if err == nil {
+			out = fmt.Sprintf("%s%s %s", key, delimiter, value)
+		} else { // FIX : add replace warring log
+			err = nil


Why make the error nil？

When I don't have a snapshot service configured, the Rendering function will introduce an error as shown in the following：

I am aware that the current approach to handling this issue is not particularly elegant. Do you have any valuable suggestions for improvement?

Maybe you can add a check before it, or talk it with your mentor or @Cyber-SiKu for a better approach.

Signed-off-by: Wine93 <[email protected]>

…ocker v24. Signed-off-by: Wine93 <[email protected]>

This reverts commit 0bff214. Signed-off-by: Wine93 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

… local path. Signed-off-by: Wine93 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

Signed-off-by: fengshunli <[email protected]> Signed-off-by: Wine93 <[email protected]>

…ner. Signed-off-by: Cyber-SiKu <[email protected]> Signed-off-by: Wine93 <[email protected]>

…oolset. Signed-off-by: Wine93 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

…urveadm's database (opencurve#206). Signed-off-by: Wine93 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

…r docker v24. Signed-off-by: Wine93 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

… v24. Signed-off-by: Wine93 <[email protected]>

Signed-off-by: montaguelhz <[email protected]>

Signed-off-by: Wine93 <[email protected]>

solution: execute the ss command in a temporary container to precheck for ports in use instead Signed-off-by: jyf111 <[email protected]>

Signed-off-by: Cyber-SiKu <[email protected]>

Signed-off-by: wanghai01 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

Signed-off-by: caoxianfei1 <[email protected]>

…ing. Signed-off-by: Wine93 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

Signed-off-by: wanghai01 <[email protected]>

Signed-off-by: Wine93 <[email protected]>

Signed-off-by: caoxianfei1 <[email protected]>

Signed-off-by: zztaki <[email protected]>

caoxianfei1 · 2023-11-24T07:25:49Z

cli/command/export.go

+
+var (
+	GET_EXPORT_PLAYBOOK_STEPS = []int{
+		playbook.SYNC_CONFIG,


Why need the step?

Originally, I used it on the cluster I had started, and the conf in the container did not render successfully, so I added it, but now it seems that this step is really not needed, and I will restart this cluster later, and then test it.

caoxianfei1 · 2023-11-24T07:26:02Z

cli/command/export.go

+)
+
+type exportOptions struct {
+	output string


--path is better?

Okay, I'll make changes

caoxianfei1 · 2023-11-24T07:27:26Z

cli/command/export.go

+)
+
+type exportOptions struct {
+	output string


which one host to export? Specify host?

I found that all hosts include curve.yaml. I think the conf in each host should be the same, so currently I have selected dcs[0], just like the implementation in the “status” command.
status.go

caoxianfei1 · 2023-11-24T07:27:51Z

cli/command/export.go

+		} else {
+			pb.AddStep(&playbook.PlaybookStep{
+				Type:    step,
+				Configs: dcs,
+				Options: map[string]interface{}{
+					comm.KEY_TOOLSV2_CONF_PATH: options.output,
+				},
+			})


caoxianfei1 · 2023-11-24T07:28:40Z

internal/task/task/common/export_toolsv2_conf.go

+	if curveadm.IsSkip(dc) {
+		return nil, nil
+	} else if err != nil {
+		return nil, err
+	} else if len(containerId) == 0 {
+		return nil, nil
+	} else if containerId == comm.CLEANED_CONTAINER_ID {
+		return nil, nil
+	}


What does mean?

I referred to the implementation of NewCollectService at that time, may be I need to evaluate whether it is necessary.

caoxianfei1 · 2023-11-24T07:29:09Z

internal/task/task/common/sync_config.go

+		if err == nil {
+			out = fmt.Sprintf("%s%s %s", key, delimiter, value)
+		} else { // FIX : add replace warring log
+			err = nil


Please refer to the discussion here. Perhaps I need to modify the logic of sync_config? Or is there any other more suitable method?

Yes, if render failed, you can open another pull request to fix it.

caoxianfei1 · 2023-11-24T07:36:46Z

BTW, please push it to develop branch again.

Signed-off-by: zztaki <[email protected]>

Signed-off-by: Liao PengFei <[email protected]>

Signed-off-by: WhereAreBugs <[email protected]>

chengyu-l and others added 3 commits April 23, 2023 18:13

update: wrong word spelling

b84a1c5

Signed-off-by: Chengyu Liu <[email protected]>

Merge pull request opencurve#211 from chengyu-l/patch-1

53f547c

update: wrong word spelling

Update topology.yaml

c561337

Signed-off-by: ilixiaocui <[email protected]>

montaguelhz reviewed Nov 14, 2023

View reviewed changes

youarefree123 force-pushed the develop branch from 61021f2 to 2f63acf Compare November 15, 2023 13:34

youarefree123 marked this pull request as draft November 17, 2023 03:45

youarefree123 marked this pull request as ready for review November 18, 2023 08:56

youarefree123 marked this pull request as draft November 18, 2023 08:57

Wine93 and others added 22 commits November 22, 2023 17:13

Improve(clean): use install instead scp to sync recycle script.

cd641e3

Signed-off-by: Wine93 <[email protected]>

Bugfix(format): make mountpoint directories with wrong mode.

8221c3b

Signed-off-by: Wine93 <[email protected]>

Release v0.2.1

a558356

Signed-off-by: Wine93 <[email protected]>

Fix(map): report warning when both --format and --quiet are set for d…

abcbae2

…ocker v24. Signed-off-by: Wine93 <[email protected]>

Revert "Bugfix(format): make mountpoint directories with wrong mode."

c38bed6

This reverts commit 0bff214. Signed-off-by: Wine93 <[email protected]>

Fix(format): use blkid instead lsblk to get block device uuid.

8068f79

Signed-off-by: Wine93 <[email protected]>

Improve: use embed module to embedded static shell scripts.

b236900

Signed-off-by: Wine93 <[email protected]>

Fix(support): download file failed by ssh when remote path is same as…

377d0a0

… local path. Signed-off-by: Wine93 <[email protected]>

Fix(deploy): wait all chunkserver online time (opencurve#114).

fa83dc4

Signed-off-by: Wine93 <[email protected]>

Fix: remove deprecated ioutil.

d7fb66e

Signed-off-by: fengshunli <[email protected]> Signed-off-by: Wine93 <[email protected]>

Makefile: add golangci-lint.

1fa2e98

Signed-off-by: fengshunli <[email protected]> Signed-off-by: Wine93 <[email protected]>

Feature: now we support execute the version 2 tools in service contai…

2b8e010

…ner. Signed-off-by: Cyber-SiKu <[email protected]> Signed-off-by: Wine93 <[email protected]>

Feature(deploy): now we support deploy curvebs cluster by specified p…

1cf0a96

…oolset. Signed-off-by: Wine93 <[email protected]>

Fix(mount): path already mounted.

5756146

Signed-off-by: Wine93 <[email protected]>

Feature: now we support the rqlite which is distributed database as c…

e2f7782

…urveadm's database (opencurve#206). Signed-off-by: Wine93 <[email protected]>

Improve(format): set reserved blocks percentage to 0 for device.

ba312cf

Signed-off-by: Wine93 <[email protected]>

Feature(hosts): support setting variable for ssh user.

3ded5dd

Signed-off-by: Wine93 <[email protected]>

Fix(format): report warning when both --format and --quiet are set fo…

b72801d

…r docker v24. Signed-off-by: Wine93 <[email protected]>

Fix(format): tune2fs not works due to the wrong command option.

aceec47

Signed-off-by: Wine93 <[email protected]>

Fix: report warning when both --format and --quiet are set for docker…

407973e

… v24. Signed-off-by: Wine93 <[email protected]>

Fix: updated usage example.

1962037

Signed-off-by: montaguelhz <[email protected]>

Fix(format): use short option for blkid command.

125a0b0

Signed-off-by: Wine93 <[email protected]>

jyf111 and others added 13 commits November 22, 2023 17:13

Improve(precheck): run ss command in container.

e771538

solution: execute the ss command in a temporary container to precheck for ports in use instead Signed-off-by: jyf111 <[email protected]>

playbook(memcache): support sudo alias.

f9830eb

Signed-off-by: Cyber-SiKu <[email protected]>

Feature(deploy): support etcd authentication.

b86b5a6

Signed-off-by: wanghai01 <[email protected]>

Improve: add commit id in version information.

11064cd

Signed-off-by: Wine93 <[email protected]>

Feature: podman can be an alternative container engine.

f39dbcd

Signed-off-by: caoxianfei1 <[email protected]>

Improve(format): support specify the number of concurrent for formatt…

49e1d41

…ing. Signed-off-by: Wine93 <[email protected]>

template: updated container image.

2cf7c66

Signed-off-by: Wine93 <[email protected]>

Feature(monitor): now we support deploy monitor.

f8de164

Signed-off-by: wanghai01 <[email protected]>

Fix(migrate): fixed migration panic.

e92745d

Signed-off-by: Wine93 <[email protected]>

Release v0.3.0

2728b7d

Signed-off-by: Wine93 <[email protected]>

fix/(curveadm-deploy): create pool need calc chunkservers

003ad85

Signed-off-by: caoxianfei1 <[email protected]>

Fix(curveadm deploy): newer version ss answers invalid arument

534e2cc

Signed-off-by: caoxianfei1 <[email protected]>

[FIX]: make build error with musl1.2.4

580b26d

Signed-off-by: zztaki <[email protected]>

youarefree123 marked this pull request as ready for review November 23, 2023 07:57

caoxianfei1 reviewed Nov 24, 2023

View reviewed changes

Fix (target start): curveadm target start timeout

9d83a9c

Signed-off-by: zztaki <[email protected]>

caoxianfei1 added the developer activities label Nov 27, 2023

youarefree123 force-pushed the develop branch from 2f63acf to 9d83a9c Compare November 30, 2023 08:50

youarefree123 marked this pull request as draft November 30, 2023 09:26

hdbdn77 and others added 4 commits December 4, 2023 16:45

docs: Quickly start developing curves based on cobra

f243ad6

Signed-off-by: Liao PengFei <[email protected]>

Feature(cluster add): add deploy type parameter

828680a

Signed-off-by: WhereAreBugs <[email protected]>

Fix(typo): fix an spelling mistake in code.

e362387

Signed-off-by: WhereAreBugs <[email protected]>

add export cmd for export the yaml that tools-v2 used

a58f65a

youarefree123 closed this Dec 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat]curveadm: add export cmd for export the yaml that tools-v2 used #344

[feat]curveadm: add export cmd for export the yaml that tools-v2 used #344

youarefree123 commented Nov 14, 2023

montaguelhz Nov 14, 2023

youarefree123 Nov 15, 2023

montaguelhz Nov 16, 2023

caoxianfei1 Nov 24, 2023

youarefree123 Nov 24, 2023

caoxianfei1 Nov 24, 2023

youarefree123 Nov 24, 2023

caoxianfei1 Nov 24, 2023

youarefree123 Nov 24, 2023

caoxianfei1 Nov 24, 2023

caoxianfei1 Nov 24, 2023

youarefree123 Nov 24, 2023

caoxianfei1 Nov 24, 2023

youarefree123 Nov 24, 2023

caoxianfei1 Nov 27, 2023

caoxianfei1 commented Nov 24, 2023

[feat]curveadm: add export cmd for export the yaml that tools-v2 used #344

[feat]curveadm: add export cmd for export the yaml that tools-v2 used #344

Conversation

youarefree123 commented Nov 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caoxianfei1 commented Nov 24, 2023