Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit-config: do not reformat schemas #548

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Nov 19, 2023

Reformatting will give spurious differences
after running the update.sh script.


📚 Documentation preview 📚: https://datacube-explorer--548.org.readthedocs.build/en/548/

@pjonsson
Copy link
Contributor Author

I'm not sure how to test this without doing an actual update and see what the precommit bot does, so I might have missed something. Considering #546, I don't want to change things too much.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7fa351) 85.88% compared to head (dd13e34) 85.88%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #548   +/-   ##
========================================
  Coverage    85.88%   85.88%           
========================================
  Files           26       26           
  Lines         3457     3457           
========================================
  Hits          2969     2969           
  Misses         488      488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Reformatting will give spurious differences
after running the update.sh script.
@pjonsson pjonsson force-pushed the precommit-exclude-schemas branch from 71e02cf to dd13e34 Compare December 2, 2023 12:40
@omad
Copy link
Member

omad commented Dec 4, 2023

Sorry if I'm explaining things you already know...

Pre-commit should be installed locally, and then pre-commit install should be run for within each repo using it.

After doing that, it's possible to do a "test run" using pre-commit run --all-files, which is AFAIK what the pre-commit service does.

@omad omad merged commit 16ba446 into opendatacube:develop Dec 4, 2023
7 checks passed
@pjonsson pjonsson deleted the precommit-exclude-schemas branch December 4, 2023 08:00
@pjonsson
Copy link
Contributor Author

pjonsson commented Dec 4, 2023

I know very little about best practices for interpreted languages, thank you for explaining!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants