Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert previous auto-modernise commits #587

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

jeremyh
Copy link
Collaborator

@jeremyh jeremyh commented Apr 8, 2024

Some changes by shed have broken the semantics of sqlalchemy queries (see #581)

  • Revert the original, offending commit that breaks result iteration.
  • Also update our usage of == None, which has a better equivalent in modern sqlalchemy (and was also broken by it)
  • Move from shed to ruff. Most of our newer repositories used ruff anyway, so it seems a good reason to switch.

I haven't retested the original issues, this is a just reverting some clear errors.

Note that ruff has made some changes of its own to match its black-like formatting, but they're minor


📚 Documentation preview 📚: https://datacube-explorer--587.org.readthedocs.build/en/587/

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.32%. Comparing base (aa0d9f3) to head (ed70628).
Report is 23 commits behind head on develop.

Files Patch % Lines
cubedash/warmup.py 0.00% 2 Missing ⚠️
cubedash/_stac.py 90.00% 1 Missing ⚠️
cubedash/generate.py 66.66% 1 Missing ⚠️
cubedash/summary/_extents.py 66.66% 1 Missing ⚠️
cubedash/summary/_schema.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #587      +/-   ##
===========================================
+ Coverage    86.29%   86.32%   +0.03%     
===========================================
  Files           26       26              
  Lines         3451     3466      +15     
===========================================
+ Hits          2978     2992      +14     
- Misses         473      474       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremyh jeremyh marked this pull request as ready for review April 8, 2024 00:37
@jeremyh jeremyh requested a review from omad April 8, 2024 00:37
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omad omad merged commit b3a4798 into opendatacube:develop Apr 8, 2024
7 checks passed
@jeremyh jeremyh deleted the jez/revert-modernise branch April 8, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants