Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerignore #597

Merged
merged 2 commits into from
May 22, 2024
Merged

Add dockerignore #597

merged 2 commits into from
May 22, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented May 11, 2024

This avoids bringing in various
local files into the docker build
context, so the docker cache will
be tainted less often, improving
the performance of image rebuilds.

If the docker cache gets in the way,
one can still use docker build --no-cache.


📚 Documentation preview 📚: https://datacube-explorer--597.org.readthedocs.build/en/597/

pjonsson added 2 commits May 11, 2024 11:59
This avoids bringing in various
local files into the docker build
context, so the docker cache will
be tainted less often, improving
the performance of image rebuilds.

If the docker cache gets in the way,
one can still use docker build --no-cache.
The comma looks like it is meant
to be a period.
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (aa0d9f3) to head (ddb3345).
Report is 118 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #597      +/-   ##
===========================================
+ Coverage    86.29%   86.32%   +0.03%     
===========================================
  Files           26       26              
  Lines         3451     3466      +15     
===========================================
+ Hits          2978     2992      +14     
- Misses         473      474       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omad omad self-assigned this May 22, 2024
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, wise.

@omad omad merged commit 9d9a163 into opendatacube:develop May 22, 2024
7 checks passed
@pjonsson pjonsson deleted the add-dockerignore branch May 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants