Skip to content

Commit

Permalink
update readme and add useful test feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Humair Khan <[email protected]>
  • Loading branch information
HumairAK committed Oct 24, 2024
1 parent 3d7b95b commit 5ad56be
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ Images:
ApiServer: quay.io/opendatahub/ds-pipelines-api-server:latest
Artifact: quay.io/opendatahub/ds-pipelines-artifact-manager:latest
OAuthProxy: registry.redhat.io/openshift4/ose-oauth-proxy:v4.12.0
PersistentAgent: quay.io/opendatahub/ds-pipelines-persistenceagent:latest
PersistenceAgent: quay.io/opendatahub/ds-pipelines-persistenceagent:latest
ScheduledWorkflow: quay.io/opendatahub/ds-pipelines-scheduledworkflow:latest
Cache: registry.access.redhat.com/ubi8/ubi-minimal
MoveResultsImage: registry.access.redhat.com/ubi8/ubi-micro
Expand Down
2 changes: 1 addition & 1 deletion controllers/testdata/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Each case requires a configmap, we can add one like this:
Images:
ApiServer: api-server:test4
Artifact: artifact-manager:test4
PersistentAgent: persistenceagent:test4
PersistenceAgent: persistenceagent:test4
ScheduledWorkflow: scheduledworkflow:test4
Cache: ubi-minimal:test4
MoveResultsImage: busybox:test4
Expand Down
16 changes: 15 additions & 1 deletion tests/dspa_v2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,21 @@ func (suite *IntegrationTestSuite) TestDSPADeployment() {
}
err := suite.Clientmgr.k8sClient.List(suite.Ctx, podList, listOpts...)
require.NoError(t, err)
assert.Equal(t, podCount, len(podList.Items))
actualPodCount := len(podList.Items)
assert.Equal(t, podCount, actualPodCount)

// Print out pod statuses for troubleshooting
if podCount != actualPodCount {
loggr.Info(fmt.Sprintf("expected %d pods to successfully deploy, got %d instead. Pods in the namespace:", podCount, actualPodCount))
totalPodList := &corev1.PodList{}
listOpts1 := []client.ListOption{
client.InNamespace(suite.DSPANamespace),
}
err := suite.Clientmgr.k8sClient.List(suite.Ctx, totalPodList, listOpts1...)
for _, pod := range totalPodList.Items {
loggr.Info(fmt.Sprintf("Pod Name: %s, Status: %s", pod.Name, pod.Status.Phase))
}
}
})
for _, deployment := range deployments {
t.Run(fmt.Sprintf("should have a ready %s deployment", deployment), func(t *testing.T) {
Expand Down

0 comments on commit 5ad56be

Please sign in to comment.