Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the component_metadata.yaml to track KFP releases across DSP ones #761

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

rimolive
Copy link
Contributor

@rimolive rimolive commented Nov 25, 2024

The issue resolved by this Pull Request:

Resolves RHOAIENG-15727

Description of your changes:

This PR introduces a new file component_metadata.yaml to track KFP releases across DSPO ones. This was a request by the Platform team so they can fetch it to ODH operator and expose in the DSCI

Testing instructions

No Testing instructions

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-761
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/761/head
git checkout -b pullrequest 8158e6998b82858cddfecbcd3ce17595621fc424
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-761"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-761

@rimolive rimolive changed the title WIP Adds the component_metadata.yaml to track KFP releases across DSP ones Adds the component_metadata.yaml to track KFP releases across DSP ones Nov 25, 2024
@dsp-developers
Copy link
Contributor

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-761

@rimolive
Copy link
Contributor Author

/retest

Copy link

@Sara4994 Sara4994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rimolive The file component_metadata.yaml looks good to me. Thanks :)

@VaniHaripriya
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: franciscojavierarceo
Once this PR has been reviewed and has the lgtm label, please ask for approval from rimolive. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit c86983a into opendatahub-io:main Nov 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants