feat: allow using custom certificates for serving #128
+443
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
insecure-tls
branch
2 times, most recently
from
5262eb0 to
c70b6ec
Compare
|
@HumairAK FYI |
leseb
changed the title
szaher
reviewed
Oct 29, 2024
|
Corresponding eval PR instructlab/eval#163 |
HumairAK
reviewed
Oct 29, 2024
HumairAK
reviewed
Oct 29, 2024
HumairAK
reviewed
Oct 29, 2024
HumairAK
reviewed
Oct 29, 2024
gmfrasca
reviewed
Oct 29, 2024
leseb
force-pushed
the
insecure-tls
branch
2 times, most recently
from
911e0fa to
c0342ec
Compare
The model serving endpoint for the judge model does not always have verified certificates, sometimes they are self-signed. The communication will be encrypted but the certificate security chain won't be valid. Now we have a new `--judge-serving-model-ca-cert` flag that allows use to use custom certificates when interacting with the judge model serving endpoint. The secret that holds the judge model serving details can be amended with a new property: `JUDGE_CA_CERT: "cm-ca-cert"` to point to the ConfigMap that contains the custom certificates bundle. Signed-off-by: Sébastien Han <[email protected]>
MichaelClifford
added a commit
that referenced
this pull request
Oct 30, 2024
feat: allow using custom certificates for serving (backport #128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b6f70d4 feat: allow using custom certificates for serving
commit b6f70d4
Author: Sébastien Han [email protected]
Date: Tue Oct 29 11:51:59 2024 +0100