Update rhoai docs to include sdg #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HumairAK
force-pushed
the
ilab-on-rhoai-read-me
branch
3 times, most recently
from
a937ca7 to
e3d0f7b
Compare
gmfrasca
reviewed
Dec 2, 2024
gmfrasca
reviewed
Dec 2, 2024
standalone/instructlab-rhoai.md
Outdated
| * On the right hand side select ‘Deploy model’ under Single-model serving platform | ||
| * Under Serving runtime choose the serving runtime `vLLM Serving Runtime for Kserve`. | ||
| * Check the `Make deployed models available through an external route` box. | ||
| * Under token authentication check the `Require token authentication` box, select the service account that we have created above. |
There was a problem hiding this comment.
Suggested change
| * Under token authentication check the `Require token authentication` box, select the service account that we have created above. | |
| * Under token authentication check the `Require token authentication` box, write the name of the service account that we have created above. |
IIRC the there's no selection mechanism here, and Dashboard will create/manage a new SA if not typed to match
gmfrasca
reviewed
Dec 2, 2024
standalone/instructlab-rhoai.md
Outdated
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: <model-server-service-account-name> |
There was a problem hiding this comment.
given that we are defining mixtral-sa explicitly for teacher, maybe we should go ahead and just name this mistral-sa, judge-sa, etc to avoid confusion
gmfrasca
reviewed
Dec 2, 2024
standalone/instructlab-rhoai.md
Outdated
| - "--judge-serving-model-secret" | ||
| - "<judge-model-details-k8s-secret>" | ||
| - "--sdg-object-store-secret" | ||
| - "<created-object-store-credentials-secret-name>" |
There was a problem hiding this comment.
i think we defined this expicitly above as sdg-object-store-credentials so might as well remove confusion and use that here
gmfrasca
reviewed
Dec 2, 2024
HumairAK
force-pushed
the
ilab-on-rhoai-read-me
branch
from
e3d0f7b to
5216ae5
Compare
As well as make various adjustments to formatting, layout, etc. Co-Authored-By: Giulio Frasca <[email protected]> Signed-off-by: Humair Khan <[email protected]>
HumairAK
force-pushed
the
ilab-on-rhoai-read-me
branch
from
5216ae5 to
159d96a
Compare
gmfrasca
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr does the following:
How Has This Been Tested?
Follow the docs.
Merge criteria: