chore: ensure pipeline params match ilab defaults #233
Conversation
tumido
force-pushed
the
phase-3-ensure-params
branch
from
f793b94 to
54ab9dd
Compare
tumido
force-pushed
the
phase-3-ensure-params
branch
2 times, most recently
from
1a3b970 to
f926bf6
Compare
tumido
changed the title
Signed-off-by: Tomas Coufal <[email protected]>
tumido
force-pushed
the
phase-3-ensure-params
branch
from
f926bf6 to
9fff4ee
Compare
@tumido do we need any changes in https://github.com/opendatahub-io/ilab-on-ocp?tab=readme-ov-file#available-pipeline-parameters? |
|
I don't think so. No param was removed or added, no description has changed... So in regard to the content we already have in the README, no change is required. However I can extend the README with default values and references, if we want to link it from there as well. 🤷 I don't have a preference there. What would you do @leseb ? 🙂 @MichaelClifford WDYT? |
Maybe as a followup if you feel like it. Thanks! |
Agree let's do it in a follow up, if at all 😄 |
Resolves #211
Description
Re-align defaults we use in the pipeline with what InstructLab declares as defaults in https://github.com/instructlab/instructlab/blob/main/tests/testdata/default_config.yaml
Each param default now features a reference to the InstructLab default config.
WIP. Some params require additional discussion. I've marked them as
FIXME:. These params have no basis in the default config and we should discuss if they need to be surfaced, if they require further justification for its default value or they are good as is. They can totally be good as is, I just wanted to raise awareness about them.