Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Kubernetes default the PVC StorageClass #80

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Let Kubernetes default the PVC StorageClass #80

merged 1 commit into from
Oct 9, 2024

Conversation

astefanutti
Copy link
Collaborator

Rely on https://kubernetes.io/docs/concepts/storage/storage-classes/#default-storageclass instead of defaulting the StorageClass client side, which is sub-optimal.

Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, please put your changes in standalone/standalone.tpl and run make standalone. Thanks!

@astefanutti
Copy link
Collaborator Author

Sorry, please put your changes in standalone/standalone.tpl and run make standalone. Thanks!

Updated, thanks!

@leseb leseb merged commit 1dae29e into main Oct 9, 2024
1 check passed
@leseb leseb deleted the pr-03 branch October 9, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants