Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kustomize manifests for kubeflow, fixes RHOAIENG-1947 #292

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Feb 7, 2024

Description

Add kustomize manifests for kubeflow
Based on ml-metadata manifests for mlmd in kubeflow pipelines.
Fixes RHOAIENG-1947

How Has This Been Tested?

WIP

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb marked this pull request as draft February 7, 2024 08:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d9144d9) 76.19% compared to head (a61c6ee) 76.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files          17       17           
  Lines        2033     2033           
  Branches       74       74           
=======================================
  Hits         1549     1549           
  Misses        299      299           
  Partials      185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirajsb dhirajsb changed the title feat: add kustomize manifests for kubeflow, fixes RHOAIENG-1947 [WIP] feat: add kustomize manifests for kubeflow, fixes RHOAIENG-1947 Feb 7, 2024
@dhirajsb
Copy link
Contributor Author

dhirajsb commented Feb 7, 2024

PR is in draft, do NOT merge!

@dhirajsb dhirajsb marked this pull request as ready for review February 17, 2024 00:42
@dhirajsb dhirajsb changed the title [WIP] feat: add kustomize manifests for kubeflow, fixes RHOAIENG-1947 feat: add kustomize manifests for kubeflow, fixes RHOAIENG-1947 Feb 17, 2024
@dhirajsb dhirajsb requested review from lampajr and removed request for rkubis February 17, 2024 00:43
@dhirajsb
Copy link
Contributor Author

@tarilabs can you approve it so that we can merge it into upstream kubeflow?

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarilabs can you approve it so that we can merge it into upstream kubeflow?

absolutely, thanks for these @dhirajsb, I understand these are manifests to use model-registry in place of Operator (say upstream KF) eventually it will be meaningful to be put under tests but given the urgency this /lgtm and we can work on placing under tests in subsequent PRs.

Copy link

openshift-ci bot commented Feb 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhirajsb, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tarilabs
Copy link
Member

@dhirajsb also for the future don't hesitate to use @opendatahub-io/model-registry-maintainers tags in Review box when needed urgent action we can rely on who's on in the timezone :) hth 👍

@tarilabs tarilabs merged commit 098ea78 into opendatahub-io:main Feb 17, 2024
11 checks passed
@dhirajsb dhirajsb deleted the kustomize-manifests branch February 18, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants