-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kustomize manifests for kubeflow, fixes RHOAIENG-1947 #292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 76.19% 76.19%
=======================================
Files 17 17
Lines 2033 2033
Branches 74 74
=======================================
Hits 1549 1549
Misses 299 299
Partials 185 185 ☔ View full report in Codecov by Sentry. |
PR is in draft, do NOT merge! |
5f884c6
to
1e57255
Compare
1e57255
to
99ab931
Compare
99ab931
to
a61c6ee
Compare
@tarilabs can you approve it so that we can merge it into upstream kubeflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarilabs can you approve it so that we can merge it into upstream kubeflow?
absolutely, thanks for these @dhirajsb, I understand these are manifests to use model-registry in place of Operator (say upstream KF) eventually it will be meaningful to be put under tests but given the urgency this /lgtm and we can work on placing under tests in subsequent PRs.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhirajsb, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dhirajsb also for the future don't hesitate to use @opendatahub-io/model-registry-maintainers tags in Review box when needed urgent action we can rely on who's on in the timezone :) hth 👍 |
Description
Add kustomize manifests for kubeflow
Based on ml-metadata manifests for mlmd in kubeflow pipelines.
Fixes RHOAIENG-1947
How Has This Been Tested?
WIP
Merge criteria: