-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-19036: chore(gha): fix workflow_dispatch invocation #881
RHOAIENG-19036: chore(gha): fix workflow_dispatch invocation #881
Conversation
Previously, triggering the GitHub action manually would not build the image, and so the tests would then fail. The cause is that we do different build commands depending whether it's builting on push, on pr, or on schedule, and for manual trigger nothing was defined.
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @andyatmiami |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
efeb9de
into
opendatahub-io:refactor/konflux-migration
/cherrypick main |
@jiridanek: new pull request created: #896 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
https://issues.redhat.com/browse/RHOAIENG-19036
Description
Previously, triggering the GitHub action manually would not build the image, and so the tests would then fail.
The cause is that we do different build commands depending whether it's builting on push, on pr, or on schedule, and for manual trigger nothing was defined.
This PR should resolve the first problem that @andyatmiami pointed out in https://issues.redhat.com/browse/RHOAIENG-19036?focusedId=26504453&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-26504453 that's regarding the manually triggered run at https://github.com/red-hat-data-services/notebooks/actions/runs/13056808219
How Has This Been Tested?
the first failure there
was an infra issue and it fixed itself in a rerun
Merge criteria: