Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-19036: chore(gha): fix workflow_dispatch invocation #881

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 1, 2025

https://issues.redhat.com/browse/RHOAIENG-19036

Description

Previously, triggering the GitHub action manually would not build the image, and so the tests would then fail.

The cause is that we do different build commands depending whether it's builting on push, on pr, or on schedule, and for manual trigger nothing was defined.

image

This PR should resolve the first problem that @andyatmiami pointed out in https://issues.redhat.com/browse/RHOAIENG-19036?focusedId=26504453&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-26504453 that's regarding the manually triggered run at https://github.com/red-hat-data-services/notebooks/actions/runs/13056808219

How Has This Been Tested?

the first failure there

Error: creating build container: initializing source docker://registry.access.redhat.com/ubi9/python-311:latest: reading manifest latest in registry.access.redhat.com/ubi9/python-311: received unexpected HTTP status: 503 Service Unavailable

was an infra issue and it fixed itself in a rerun

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Previously, triggering the GitHub action manually would not build the image, and so the tests would then fail.

The cause is that we do different build commands depending whether it's builting on push, on pr, or on schedule, and for manual trigger nothing was defined.
@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 February 1, 2025 09:51
@openshift-ci openshift-ci bot added size/s and removed size/s labels Feb 1, 2025
@jiridanek jiridanek added the good first issue Good for newcomers label Feb 1, 2025
@jiridanek jiridanek changed the base branch from main to refactor/konflux-migration February 4, 2025 10:37
@openshift-ci openshift-ci bot added size/s and removed size/s labels Feb 4, 2025
@jiridanek
Copy link
Member Author

/override ci/prow/images
infra issues, and not applicable for the changes

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images
infra issues, and not applicable for the changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/cc @andyatmiami

@openshift-ci openshift-ci bot requested a review from andyatmiami February 4, 2025 10:42
@jstourac
Copy link
Member

jstourac commented Feb 4, 2025

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit efeb9de into opendatahub-io:refactor/konflux-migration Feb 4, 2025
7 checks passed
@jiridanek jiridanek deleted the jd_workflow_dispatch branch February 4, 2025 11:24
@jiridanek
Copy link
Member Author

/cherrypick main

@openshift-cherrypick-robot

@jiridanek: new pull request created: #896

In response to this:

/cherrypick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants