Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-19036: chore(gha): fix workflow_dispatch invocation #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 1, 2025

https://issues.redhat.com/browse/RHOAIENG-19036

Description

Previously, triggering the GitHub action manually would not build the image, and so the tests would then fail.

The cause is that we do different build commands depending whether it's builting on push, on pr, or on schedule, and for manual trigger nothing was defined.

image

This PR should resolve the first problem that @andyatmiami pointed out in https://issues.redhat.com/browse/RHOAIENG-19036?focusedId=26504453&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-26504453 that's regarding the manually triggered run at https://github.com/red-hat-data-services/notebooks/actions/runs/13056808219

How Has This Been Tested?

the first failure there

Error: creating build container: initializing source docker://registry.access.redhat.com/ubi9/python-311:latest: reading manifest latest in registry.access.redhat.com/ubi9/python-311: received unexpected HTTP status: 503 Service Unavailable

was an infra issue and it fixed itself in a rerun

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Previously, triggering the GitHub action manually would not build the image, and so the tests would then fail.

The cause is that we do different build commands depending whether it's builting on push, on pr, or on schedule, and for manual trigger nothing was defined.
@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 February 1, 2025 09:51
Copy link
Contributor

openshift-ci bot commented Feb 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jiridanek. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/s and removed size/s labels Feb 1, 2025
@jiridanek jiridanek added the good first issue Good for newcomers label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant