fix: fetching gvk from scheme requires error handling (#305)

Signed-off-by: Tomer Figenblat <[email protected]>
(cherry picked from commit 545ac11)

controllers/nim_account_controller.go

@@ -301,8 +301,13 @@ func (r *NimAccountReconciler) reconcileRuntimeTemplate(ctx context.Context, acc
 
 		template.Labels = labels
 
+		sr, srErr := utils.GetNimServingRuntimeTemplate(r.Scheme())
+		if srErr != nil {
+			return srErr
+		}
+
 		template.Objects = []runtime.RawExtension{
-			{Object: utils.GetNimServingRuntimeTemplate(r.Scheme())},
+			{Object: sr},
 		}
 		return nil
 	}); err != nil {

controllers/utils/nim.go

@@ -289,7 +289,7 @@ func getModelData(runtime NimRuntime, tokenResp *NimTokenResponse) (*NimModel, s
 }
 
 // GetNimServingRuntimeTemplate returns the Template used by ODH for creating serving runtimes
-func GetNimServingRuntimeTemplate(scheme *runtime.Scheme) *v1alpha1.ServingRuntime {
+func GetNimServingRuntimeTemplate(scheme *runtime.Scheme) (*v1alpha1.ServingRuntime, error) {
 	multiModel := false
 	sr := &v1alpha1.ServingRuntime{
 		ObjectMeta: metav1.ObjectMeta{
@@ -378,8 +378,11 @@ func GetNimServingRuntimeTemplate(scheme *runtime.Scheme) *v1alpha1.ServingRunti
 		},
 	}
 
-	gvk, _ := apiutil.GVKForObject(sr, scheme)
+	gvk, err := apiutil.GVKForObject(sr, scheme)
+	if err != nil {
+		return nil, err
+	}
 	sr.SetGroupVersionKind(gvk)
 
-	return sr
+	return sr, nil
 }