Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.ubi: add missing dependency #122

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented Aug 6, 2024

requirements-adag.txt (required for ray accelerated dag) is required as part of of requirements-dev.txt -> requirements-test.txt

Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 6, 2024

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test b94ac66 link true /test smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro
Copy link
Author

dtrifiro commented Aug 7, 2024

Waiting on a new vllm-tgis-adapter release(see opendatahub-io/vllm-tgis-adapter#82)

Waiting on #126

@dtrifiro
Copy link
Author

Smoke test is failing because #126 is missing. Merging this and retriggering CI for #126

@dtrifiro dtrifiro merged commit f850e50 into opendatahub-io:main Aug 12, 2024
18 of 20 checks passed
@dtrifiro dtrifiro deleted the fix-dockerfile branch August 12, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant