-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix smoke tests #299
[CI] Fix smoke tests #299
Conversation
Looks great. Let's see if CI passes 😅 |
Yeah I wish..
Other jobs are still pending though, I thought the smoke-test was supposed to run after the |
@NickLucche: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Given that the image mirror steps succeed and the smoke test fails, I suspect that the failing jobs are the ones scheduled on build05 |
86e5339
to
9e5a88d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro, NickLucche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: NickLucche <[email protected]>
smoke-test.sh
currently throws cuda OOM errors due to forced shutdown of vLLM, which results in leaving cuda memory allocated. We wait for a gracious shutdown and use a helper script to print out stats about gpu memory, in case similar issues arise again.