Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix smoke tests #299

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[CI] Fix smoke tests #299

merged 1 commit into from
Jan 23, 2025

Conversation

NickLucche
Copy link

smoke-test.sh currently throws cuda OOM errors due to forced shutdown of vLLM, which results in leaving cuda memory allocated. We wait for a gracious shutdown and use a helper script to print out stats about gpu memory, in case similar issues arise again.

extras/smoke-test.sh Outdated Show resolved Hide resolved
@dtrifiro
Copy link

dtrifiro commented Jan 22, 2025

Looks great. Let's see if CI passes 😅

@NickLucche
Copy link
Author

Looks great. Let's see if CI passes 😅

Yeah I wish..

�[36mINFO�[0m[2025-01-22T15:53:45Z] Build vllm-build-main-cuda-amd64 failed, printing logs: 
unable to retrieve container logs for cri-o://3991e41e9b2c5fddb955c7af723fb20e8c721587f0474d8abdc0ec7126316da1unable to retrieve container logs for cri-o://e4f0136398891296951e81f65771b4eac8399f5f411b7ec284cc41398dd701d7unable to retrieve container logs for cri-o://37e59768b199c3d88e31c1d16cc90920dbc6008812f614bfb39c45eb6f89b51e�[36mINFO�[0m[2025-01-22T15:53:45Z] Build vllm-build-main-cuda-amd64 previously failed from an infrastructure error (BuildPodEvicted), retrying... 

Other jobs are still pending though, I thought the smoke-test was supposed to run after the prow/images* jobs completed.. Might there be some "timing" issue?

Copy link

openshift-ci bot commented Jan 22, 2025

@NickLucche: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test 86e5339 link true /test smoke-test
ci/prow/images 86e5339 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro
Copy link

Given that the image mirror steps succeed and the smoke test fails, I suspect that the failing jobs are the ones scheduled on build05

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, NickLucche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [NickLucche,dtrifiro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: NickLucche <[email protected]>
@NickLucche NickLucche enabled auto-merge (rebase) January 23, 2025 13:40
@NickLucche NickLucche disabled auto-merge January 23, 2025 13:40
@NickLucche NickLucche merged commit 6748673 into main Jan 23, 2025
3 of 8 checks passed
@NickLucche NickLucche deleted the fix-smoke-tests branch January 23, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants