Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.ubi: remove vllm-nccl workaround #51

Merged

Conversation

dtrifiro
Copy link

Fixed upstream in vllm-project#5091

@openshift-ci openshift-ci bot requested review from heyselbi and rpancham June 13, 2024 08:26
Copy link

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtn
/approve

Copy link

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, z103cb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@z103cb
Copy link

z103cb commented Jun 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d9ec43c into opendatahub-io:main Jun 13, 2024
16 checks passed
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
…patch-1

Revert "Tune fused_moe_kernel for TP 1,2,4,8 and bf16 and fp16, updated moe kern…"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants