Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with [email protected] #57

Merged
merged 37 commits into from
Jun 21, 2024
Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot added the code-sync Sync with upstream label Jun 19, 2024
@openshift-ci openshift-ci bot requested review from rpancham and z103cb June 19, 2024 04:30
Copy link

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign spolti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jun 19, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@z103cb
Copy link

z103cb commented Jun 19, 2024

/ok-to-test

@dtrifiro dtrifiro marked this pull request as draft June 19, 2024 11:45
zifeitong and others added 18 commits June 19, 2024 13:57
Signed-off-by: Thomas Parnell <[email protected]>

Co-authored-by: Thomas Parnell <[email protected]>
Co-authored-by: Nick Hill <[email protected]>
Co-authored-by: Davis Wertheimer <[email protected]>
@dtrifiro dtrifiro added the lgtm label Jun 21, 2024
@dtrifiro dtrifiro marked this pull request as ready for review June 21, 2024 11:27
@openshift-ci openshift-ci bot requested a review from dtrifiro June 21, 2024 11:27
@dtrifiro dtrifiro merged this pull request into opendatahub-io:main Jun 21, 2024
13 of 15 checks passed
Xaenalt pushed a commit that referenced this pull request Sep 18, 2024
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
* add quantization_weights_path for fp8 weights

* fix lint

* fix lint

* change to quantized_weights_path

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.