Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weights to daily model #536

Merged
merged 22 commits into from
Feb 6, 2025
Merged

Conversation

travis-recurve
Copy link
Contributor

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a feature/bugfix branch (right side). Don't request your master!
  • Make sure tests pass and coverage has not fallen docker-compose run --rm test.
  • Update the CHANGELOG.md to describe your changes in a bulleted list under the "Development" section at the top of the changelog. If this section does not exist, create it.
  • Make sure code style follows PEP 008 using docker-compose run --rm blacken.
  • Make sure that new functions and classes have inline docstrings valid docstrings and any public classes and methods are included members in the docs/reference files. Please use google-style docstrings.
    Sphinx docs can be built with the following command: docker-compose run --rm --entrypoint="make -C docs html" shell. Please note and fix any warnings.
  • Make sure that all git commits are have the "Signed-off-by" message for
    the Developer Certificate of Origin. When you're making a commit, just add
    the -s/--signoff flag (e.g., git commit -s).

Description

  • Converted all daily settings from attrs to pydantic to match hourly
  • Altered initial optimization to use the optimizer class instead of being hard coded
  • Added very clunky billing data changes to get closer to proper billing model
  • Weights propagate from data class to objective function by searching for column named 'weights" in dataframe

Signed-off-by: travis-recurve <[email protected]>
Signed-off-by: travis-recurve <[email protected]>
Signed-off-by: travis-recurve <[email protected]>
@travis-recurve travis-recurve force-pushed the feature/daily_model_weights branch from 06836ab to bb10da1 Compare January 27, 2025 03:15
@travis-recurve travis-recurve force-pushed the feature/daily_model_weights branch from 7922c38 to 3635afc Compare January 31, 2025 02:45
Signed-off-by: travis-recurve <[email protected]>
@travis-recurve travis-recurve force-pushed the feature/daily_model_weights branch from 755c7fd to 92b565b Compare February 4, 2025 22:28
Signed-off-by: travis-recurve <[email protected]>
@travis-recurve travis-recurve marked this pull request as ready for review February 4, 2025 22:52
@travis-recurve travis-recurve requested review from canchola-recurve and removed request for C-Canchola February 6, 2025 16:25
@travis-recurve travis-recurve merged commit 09fbcc2 into master Feb 6, 2025
17 checks passed
@travis-recurve travis-recurve deleted the feature/daily_model_weights branch February 6, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants