fix: quota is not calculated correctly #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
MingZhang-YBPS
changed the title
MingZhang-YBPS
changed the title
MingZhang-YBPS
force-pushed
the
fix-quota-calc
branch
2 times, most recently
from
9ba0bf3 to
17b3db9
Compare
|
@niladrih could you please help to review? |
niladrih
reviewed
Sep 5, 2023
MingZhang-YBPS
force-pushed
the
fix-quota-calc
branch
from
f3f052f to
d08acc7
Compare
Signed-off-by: 张铭 <[email protected]>
Signed-off-by: 张铭 <[email protected]>
Signed-off-by: 张铭 <[email protected]>
Signed-off-by: 张铭 <[email protected]> Signed-off-by: 张铭 <[email protected]>
MingZhang-YBPS
force-pushed
the
fix-quota-calc
branch
from
71f12c6 to
fb8c03f
Compare
@niladrih Done, could you please help to have a look again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Why is this PR required? What issue does it fix?:
If the pvc storage is 1G, which means 1073741824Byte. The quota returned from convertToK() is 1073742k which is bigger than expected. While, the correct result shall be 1048576k
What this PR does?:
Fix the quota calculation logic
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
The same scenariom, the quota returned is 1048576k after fix
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>