Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add support for incremental builds and helm charts #204

Merged
merged 28 commits into from
Nov 6, 2024
Merged

ci: add support for incremental builds and helm charts #204

merged 28 commits into from
Nov 6, 2024

Conversation

pchandra19
Copy link
Contributor

CI-enhancements

pchandra19 and others added 4 commits October 17, 2024 13:50
Abhinandan-Purkait
Abhinandan-Purkait approved these changes Oct 22, 2024
View reviewed changes
niladrih
niladrih reviewed Oct 23, 2024
View reviewed changes
Abhinandan-Purkait
Abhinandan-Purkait reviewed Oct 24, 2024
View reviewed changes
Abhinandan-Purkait
Abhinandan-Purkait reviewed Oct 24, 2024
View reviewed changes
Abhinandan-Purkait
Abhinandan-Purkait reviewed Oct 24, 2024
View reviewed changes
@Abhinandan-Purkait
Copy link
Member

You would need to add the scripts and also need to fix the code coverage bit as well.

@pchandra19
fix: added scripts for charts
8be5764 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: scripts permissions
e8c2ec7 
Signed-off-by: Prateek Chandra <[email protected]>
Abhinandan-Purkait
Abhinandan-Purkait requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the chart version, the CI is still failing.

@pchandra19
fix: chart version and code cov
66f8e10 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: test make file target
3dfd9d2 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: added missed step
ef01228 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: missin namespace
e00db45 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: added kubectl get pods
b57249e 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: image tags
8ee2491 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: change job name and image tag
22edb0b 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: image tag
937a674 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: image tags
134e8f5 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: image tag
21142a6 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: remove ci refs
245bb57 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: remove ci tag from build.sh
9c74671 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: release version
dee5d7e 
Signed-off-by: Prateek Chandra <[email protected]>
niladrih
niladrih requested changes Nov 5, 2024
View reviewed changes
@pchandra19
fix: remove release chart.yml
1cbc60f 
Signed-off-by: Prateek Chandra <[email protected]>
niladrih
niladrih requested changes Nov 5, 2024
View reviewed changes
Abhinandan-Purkait
Abhinandan-Purkait reviewed Nov 5, 2024
View reviewed changes
@Abhinandan-Purkait Abhinandan-Purkait dismissed their stale review November 5, 2024 13:45

Needs more changes

niladrih
niladrih reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Looks good for the most part. Thanks.

@pchandra19
fix: hardcoded paths as sugested
21cb056 
Signed-off-by: Prateek Chandra <[email protected]>
niladrih
niladrih approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test coverage aside. CI looks good to me.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.35%. Comparing base (cab53c4) to head (3908177).
Report is 4 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
- Coverage    37.91%   37.35%   -0.57%     
===========================================
  Files           36        1      -35     
  Lines         3373      779    -2594     
===========================================
- Hits          1279      291     -988     
+ Misses        2012      479    -1533     
+ Partials        82        9      -73
Flag Coverage Δ
integrationtests 37.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niladrih niladrih changed the title Ci enhancements ci: add support for incremental builds and helm charts Nov 6, 2024
@niladrih niladrih merged commit 2e2234e into openebs:develop Nov 6, 2024
5 checks passed
niladrih pushed a commit to niladrih/dynamic-localpv-provisioner that referenced this pull request Nov 27, 2024
@pchandra19 @niladrih
ci: add support for incremental builds and helm charts (openebs#204)
2eb9e00 
Signed-off-by: Prateek Chandra <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
niladrih added a commit that referenced this pull request Nov 28, 2024
@niladrih @emosbaugh @pchandra19
Cherry-pick fixes and CI to release/4.1 (#215)
7c17151 
* fix(analytics): respect environment variable to disable reporting event analytics (#211)

Signed-off-by: Ethan Mosbaugh <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>

* ci: add support for incremental builds and helm charts (#204)

Signed-off-by: Prateek Chandra <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>

* ci: fix build_and_push awk command (#212)

Signed-off-by: Niladri Halder <[email protected]>

* ci: fix build_and_push and release workflows (#213)

Signed-off-by: Niladri Halder <[email protected]>

---------

Signed-off-by: Ethan Mosbaugh <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Prateek Chandra <[email protected]>
Co-authored-by: Ethan Mosbaugh <[email protected]>
Co-authored-by: Prateek Chandra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niladrih niladrih niladrih approved these changes

@tiagolobocastro tiagolobocastro Awaiting requested review from tiagolobocastro

@Abhinandan-Purkait Abhinandan-Purkait Awaiting requested review from Abhinandan-Purkait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pchandra19 @Abhinandan-Purkait @codecov-commenter @niladrih