Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(event): add NodeCount, ReplicaCount, VolumeCapacity event fields #8

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Jun 14, 2024

There were two sets of values sent for two different sets of engines:

  1. cStor, Jiva --> Replica Count, Capacity
  2. Zfs/LVM/Hostpath LocalPV --> "Running", Node count

It was either or for these values. The Event Category, Action, Label and Value stucture was ported directly from Google Analytics UA's event structure.

This PR removes Event Action, Label and Value and replaces them with 'NodeCount', 'ReplicaCount' and 'VolumeCapacity'. These 3 fields sit directly on the event body (similar to node arch and node OS).

@niladrih
Copy link
Member Author

@Abhinandan-Purkait -- Thank you for your review! I've asked you for a second review because I've changed the implementation from what it was when you had reviewed it.

@Abhinandan-Purkait
Copy link
Member

Abhinandan-Purkait commented Jun 17, 2024

Looks, good. Is it a good idea to collect the sc params as a field as well? Maybe call that field ExtraInfo can be a generic field to add extra stuffs whenever we want. One immediate example could be on volume_provision events we set ExtraInfo to sc params. That would help us track what kind of configs people use.

@niladrih niladrih changed the title feat(event): add Nodes as an Event member feat(event): add NodeCount, ReplicaCount, VolumeCapacity event fields Jun 17, 2024
@niladrih
Copy link
Member Author

Looks, good. Is it a good idea to collect the sc params as a field as well? Maybe call that field ExtraInfo can be a generic field to add extra stuffs whenever we want. One immediate example could be on volume_provision events we set ExtraInfo to sc params. That would help us track what kind of configs people use.

This needs more discussion. This might be a good item for the next maintainers' meeting. I'm going to hold off on this change for now.

@niladrih niladrih merged commit cf0a565 into develop Jun 20, 2024
2 checks passed
@niladrih niladrih deleted the name-changes branch June 20, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants