-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event): add NodeCount, ReplicaCount, VolumeCapacity event fields #8
Conversation
36a13bf
to
be9ade4
Compare
@Abhinandan-Purkait -- Thank you for your review! I've asked you for a second review because I've changed the implementation from what it was when you had reviewed it. |
Looks, good. Is it a good idea to collect the sc params as a field as well? Maybe call that field |
This needs more discussion. This might be a good item for the next maintainers' meeting. I'm going to hold off on this change for now. |
Signed-off-by: Niladri Halder <[email protected]>
…IEC units Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
There were two sets of values sent for two different sets of engines:
It was either or for these values. The Event Category, Action, Label and Value stucture was ported directly from Google Analytics UA's event structure.
This PR removes Event Action, Label and Value and replaces them with 'NodeCount', 'ReplicaCount' and 'VolumeCapacity'. These 3 fields sit directly on the event body (similar to node arch and node OS).