docs: remove the io_timeout parameter from the storage-class since this is now being passed as a command-line argument to io-engine #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avishnu
changed the title
…d-line argument to io-engine Signed-off-by: Vishnu Attur <[email protected]>
avishnu
force-pushed
the
remove-iotimeout-from-sc-params
branch
from
0d39364 to
32c207d
Compare
tiagolobocastro
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Might want to document ctrl-loss-tmo on another section? It's configurable via helm csi.node.ctrl_loss_tmo
https://github.com/openebs/mayastor-extensions/blob/a1a16e89d66278c1153c36b09b491482349bc708/chart/values.yaml#L322C28-L322C28
There was a problem hiding this comment.
Makes sense. Will take up in a separate PR.
Abhinandan-Purkait
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.