docs(snapshot.md): fixed broken urls again using absolute path #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ Currently, Mayastor supports the following operations related to volume snapshot | |||
| ## Prerequisites | |||
|
|
|||
|
|
|||
| 1. Deploy and configure Mayastor by following the steps given [here](quickstart/deploy-mayastor.md) and create disk pools. | |||
| 1. Deploy and configure Mayastor by following the steps given [here](https://mayastor.gitbook.io/introduction/quickstart/deploy-mayastor.md) and create disk pools. | |||
There was a problem hiding this comment.
Previous PR had used relative path, example: ../
If that works it'd be better IMHO
There was a problem hiding this comment.
I've tried using the relative path but it's not working. So, I've used the absolute path to fix the issue.
There was a problem hiding this comment.
The relative path change is already live, but not working. Not sure of the reason. Also noticed that elsewhere in the docs, we seem to have used absolute paths (except SUMMARY which is at top-level).
|
There is a conflict in your branch that needs to be resolved. Most likely, you haven't rebased your local branch with the remote. |
Signed-off-by: Vikas Gaur <[email protected]>
|
@avishnu @tiagolobocastro I've fixed the conflict. Please review. |
tiagolobocastro
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.