Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #196 to version/2.3 #201

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Cherry-pick #196 to version/2.3 #201

merged 1 commit into from
Jan 25, 2024

Conversation

vikgaur
Copy link
Contributor

@vikgaur vikgaur commented Jan 24, 2024

The change cherry-picks the commits from #196 to version/2.3

@avishnu
Copy link
Member

avishnu commented Jan 24, 2024

There are conflicts in this PR. Check the changes please

@vikgaur
Copy link
Contributor Author

vikgaur commented Jan 24, 2024

@avishnu, made the changes. Please take a look.

@avishnu
Copy link
Member

avishnu commented Jan 24, 2024

@avishnu, made the changes. Please take a look.

the conflicts have been resolved, but there are absolute links (pointing to a wrong branch) instead of relative links. Also, the change in deploy-mayastor.md is not included.

Signed-off-by: Vishnu Attur <[email protected]>
Signed-off-by: Vikas Gaur <[email protected]>
@vikgaur
Copy link
Contributor Author

vikgaur commented Jan 25, 2024

@avishnu fixed the issue. Please review.

Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@avishnu avishnu merged commit 748a51c into version/2.3 Jan 25, 2024
2 checks passed
@avishnu avishnu deleted the cherry-links-2.3 branch January 25, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants