Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(bors): merge pull request #584
584: chore: fix helm-testing versioning in publish-chart-yaml r=blaisedias a=blaisedias Fix helm testing version generation ## Description Replace hard coded patch and minor values of 0, with values derived from the chart version That way we get versions derived from chart/Chart.yaml, like 2.7.2-... instead of hard coded values like 2.7.0-... or 2.0.0-.... ## Motivation and Context This change is required to build with version numbers that monotonically increase This makes is possible to test upgrades with setting override flags. ## Regression Is this PR fixing a regression? No ## How Has This Been Tested? tested by executing the modified script using the command line ``` nix-shell --pure --run './scripts/helm/publish-chart-yaml.sh --helm-testing helm-testing/release/2.7 --date-time 2024-12-11-10-21-41' ./scripts/helm/shell.nix ``` ## Types of changes - [x ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [x ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added unit tests to cover my changes. Co-authored-by: Blaise Dias <[email protected]>
- Loading branch information