You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't this feature be more generic? As in an option to disable any one of the engines?
Yes. I have now removed changes to handle environment variable setting
Shouldn't this feature be more generic? As in an option to disable any one of the engines?
Yes. I have now removed changes to handle environment variable setting
The name is still DisableLocalEngines , it should be DisableEngines.
Configuration using an environment variable is a useful flexibility - it should be present.
The same means should be used to disable all IO engines including mayastor.
Shouldn't this feature be more generic? As in an option to disable any one of the engines?
Yes. I have now removed changes to handle environment variable setting
The name is still DisableLocalEngines , it should be DisableEngines. Configuration using an environment variable is a useful flexibility - it should be present. The same means should be used to disable all IO engines including mayastor.
I have modified the name to "DisableEngines". However environment variable is not present as I removed the logic to handle it in the pipelines code
This change will add a configuration variable to disable
installation of local engines lvm and zfs during
umbrella chart based installation
Signed-off-by: Ranjith M P <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r1jt
force-pushed
the
disable-local-engines
branch
from
This change will add a configuration variable to disable
installation of local engines lvm and zfs during
umbrella chart based installation