chore: e2e_config: rationalisations and fixes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blaisedias
commented
Oct 28, 2024
blaisedias
commented
- remove unused configuration items
- remove caching of configuration values this breaks recording of configuration used for testing.
blaisedias
force-pushed
the
e2e-config-rationalise
branch
from
996991a to
c61439d
Compare
blaisedias
requested review from
rohan2794,
harshshekhar15,
w3aman and
r1jt
and removed request for
harshshekhar15
rohan2794
approved these changes
Oct 29, 2024
blaisedias
force-pushed
the
e2e-config-rationalise
branch
from
c61439d to
3953853
Compare
- remove unused configuration items - remove caching of configuration values this breaks recording of configuration used for testing. Signed-off-by: Blaise Dias <[email protected]>
blaisedias
force-pushed
the
e2e-config-rationalise
branch
from
3953853 to
ce205e8
Compare
w3aman
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.