feat(bdev): Add support for CSAL FTL bdev targets #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
approved these changes
Nov 14, 2024
At the same time prepare for potential zoned storage enabled CSAL FTLs. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Indraneel M <[email protected]> Signed-off-by: Dennis Maisenbacher <[email protected]>
MaisenbacherD
force-pushed
the
csal-support
branch
from
f7a82bd to
0fb3086
Compare
|
I fixed the conventional commit linter errors :) |
dsharma-dc
approved these changes
Nov 14, 2024
MaisenbacherD
added a commit
to MaisenbacherD/spdk-rs
that referenced
this pull request
Nov 27, 2024
Add back `--without-uring-zns` spdk config that was removed in 2578b43 ("feat(bdev): add support for CSAL ftl bdev targets (openebs#67)") for preparation on potential future spdk ftl features. The uring-zns spdk feature caused errors in the `core` cargo test: ``` ... ERROR mayastor::spdk:bdev_uring.c:591] Unable to open file /tmp/disk3.img/queue/zoned. errno: 2 ... ``` For now the uring-zns spdk feature is not necessary. Signed-off-by: Dennis Maisenbacher <[email protected]>
tiagolobocastro
pushed a commit
that referenced
this pull request
Nov 27, 2024
Add back `--without-uring-zns` spdk config that was removed in 2578b43 ("feat(bdev): add support for CSAL ftl bdev targets (#67)") for preparation on potential future spdk ftl features. The uring-zns spdk feature caused errors in the `core` cargo test: ``` ... ERROR mayastor::spdk:bdev_uring.c:591] Unable to open file /tmp/disk3.img/queue/zoned. errno: 2 ... ``` For now the uring-zns spdk feature is not necessary. Signed-off-by: Dennis Maisenbacher <[email protected]>
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor
that referenced
this pull request
Nov 28, 2024
1771: Introduce new CSAL ftl bdev r=tiagolobocastro a=MaisenbacherD For this PR to be merged the PR openebs/spdk-rs#67 for spdk-rs needs to be resolved and the submodule reference must be updated accordingly. :) The SPDK ftl bdev allows to create a layered device with a (fast) cache device for buffering writes that get eventually flushed out sequentially to a base device. SDPK ftl is also known as the Cloud Storage Acceleration Layer (CSAL). This kind of device potentially enables the use of emerging storage interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP) capable NVMe devices. Up to this point, those NVMe command sets are not yet supported in SPDK upstream. However, the acceleration aspect of a fast cache device already adds value. With future support of new devices for SDPK ftl, Mayastor would already be capable of utilizing those features simply by upgrading SDPK. For now, the `ftl_mount_fs` test cases are hidden behind the `ignore` attribute because PCIe devices are required for this test until SPDK v24.09 is picked up, which introduces variable sector size emulation for ftl devices. To run these tests use the following: ``` RUST_LOG=TRACE cargo test -- --test-threads 1 --test ftl_mount_fs --nocapture --ignored ``` This patch introduces a new ftl device uri scheme: ``` ftl:///<ftl-device-name>?bbdev=<dev-uri-nested-encoding>&cbdev=<dev-uri-nested-encoding> ``` `<dev-uri-nested-encoding>` can be any already valid device uri where '?' are replaced with '!' and '&' are replaced with '|'. With SPDK v24.05 only PCIe devices will work where the cache device is formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format. From SPDK v24.09 on, any device with a block size of 4KiB will work for both cache and base device. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Dennis Maisenbacher <[email protected]>
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor
that referenced
this pull request
Nov 28, 2024
1771: Introduce new CSAL ftl bdev r=tiagolobocastro a=MaisenbacherD For this PR to be merged the PR openebs/spdk-rs#67 for spdk-rs needs to be resolved and the submodule reference must be updated accordingly. :) The SPDK ftl bdev allows to create a layered device with a (fast) cache device for buffering writes that get eventually flushed out sequentially to a base device. SDPK ftl is also known as the Cloud Storage Acceleration Layer (CSAL). This kind of device potentially enables the use of emerging storage interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP) capable NVMe devices. Up to this point, those NVMe command sets are not yet supported in SPDK upstream. However, the acceleration aspect of a fast cache device already adds value. With future support of new devices for SDPK ftl, Mayastor would already be capable of utilizing those features simply by upgrading SDPK. For now, the `ftl_mount_fs` test cases are hidden behind the `ignore` attribute because PCIe devices are required for this test until SPDK v24.09 is picked up, which introduces variable sector size emulation for ftl devices. To run these tests use the following: ``` RUST_LOG=TRACE cargo test -- --test-threads 1 --test ftl_mount_fs --nocapture --ignored ``` This patch introduces a new ftl device uri scheme: ``` ftl:///<ftl-device-name>?bbdev=<dev-uri-nested-encoding>&cbdev=<dev-uri-nested-encoding> ``` `<dev-uri-nested-encoding>` can be any already valid device uri where '?' are replaced with '!' and '&' are replaced with '|'. With SPDK v24.05 only PCIe devices will work where the cache device is formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format. From SPDK v24.09 on, any device with a block size of 4KiB will work for both cache and base device. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Dennis Maisenbacher <[email protected]>
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor
that referenced
this pull request
Nov 28, 2024
1771: Introduce new CSAL ftl bdev r=tiagolobocastro a=MaisenbacherD For this PR to be merged the PR openebs/spdk-rs#67 for spdk-rs needs to be resolved and the submodule reference must be updated accordingly. :) The SPDK ftl bdev allows to create a layered device with a (fast) cache device for buffering writes that get eventually flushed out sequentially to a base device. SDPK ftl is also known as the Cloud Storage Acceleration Layer (CSAL). This kind of device potentially enables the use of emerging storage interfaces like Zoned Namespace (ZNS) or Flexible Data Placement (FDP) capable NVMe devices. Up to this point, those NVMe command sets are not yet supported in SPDK upstream. However, the acceleration aspect of a fast cache device already adds value. With future support of new devices for SDPK ftl, Mayastor would already be capable of utilizing those features simply by upgrading SDPK. For now, the `ftl_mount_fs` test cases are hidden behind the `ignore` attribute because PCIe devices are required for this test until SPDK v24.09 is picked up, which introduces variable sector size emulation for ftl devices. To run these tests use the following: ``` RUST_LOG=TRACE cargo test -- --test-threads 1 --test ftl_mount_fs --nocapture --ignored ``` This patch introduces a new ftl device uri scheme: ``` ftl:///<ftl-device-name>?bbdev=<dev-uri-nested-encoding>&cbdev=<dev-uri-nested-encoding> ``` `<dev-uri-nested-encoding>` can be any already valid device uri where '?' are replaced with '!' and '&' are replaced with '|'. With SPDK v24.05 only PCIe devices will work where the cache device is formatted to 4KiB+64B LBA format and the base device to 4KiB LBA format. From SPDK v24.09 on, any device with a block size of 4KiB will work for both cache and base device. CSAL paper reference: https://dl.acm.org/doi/10.1145/3627703.3629566 Co-authored-by: Dennis Maisenbacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time prepare for potential zoned storage enabled CSAL FTLs.
CSAL paper reference:
https://dl.acm.org/doi/10.1145/3627703.3629566